Re: [PATCH v4 1/4] worktree: improve message when creating a new worktree

2018-03-24 Thread Thomas Gummerer
On 03/20, Eric Sunshine wrote: > On Sat, Mar 17, 2018 at 6:22 PM, Thomas Gummerer wrote: > > [...] > > Fix these inconsistencies, and no longer show the identifier by making > > the 'git reset --hard' call quiet, and printing the message directly > > from the builtin command

Re: [PATCH v4 1/4] worktree: improve message when creating a new worktree

2018-03-20 Thread Eric Sunshine
On Sat, Mar 17, 2018 at 6:22 PM, Thomas Gummerer wrote: > [...] > Fix these inconsistencies, and no longer show the identifier by making > the 'git reset --hard' call quiet, and printing the message directly > from the builtin command instead. > > Signed-off-by: Thomas

Re: [PATCH v4 1/4] worktree: improve message when creating a new worktree

2018-03-19 Thread Junio C Hamano
Duy Nguyen writes: >> @@ -320,10 +318,19 @@ static int add_worktree(const char *path, const char >> *refname, >> if (ret) >> goto done; >> >> + fprintf(stderr, _("worktree HEAD is now at %s"), > > We use the term "working tree" for UI and

Re: [PATCH v4 1/4] worktree: improve message when creating a new worktree

2018-03-19 Thread Duy Nguyen
On Sat, Mar 17, 2018 at 11:22 PM, Thomas Gummerer wrote: > Currently 'git worktree add' produces output like the following, when > '--no-checkout' is not given: > > Preparing foo (identifier foo) > HEAD is now at 26da330922 > > where the first line is written to

[PATCH v4 1/4] worktree: improve message when creating a new worktree

2018-03-17 Thread Thomas Gummerer
Currently 'git worktree add' produces output like the following, when '--no-checkout' is not given: Preparing foo (identifier foo) HEAD is now at 26da330922 where the first line is written to stderr, and the second line coming from 'git reset --hard' is written to stdout, even though