Re: [PATCH v4 11/11] pack-objects.h: reorder members to shrink struct object_entry

2018-03-17 Thread Duy Nguyen
On Fri, Mar 16, 2018 at 10:02 PM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> Previous patches leave lots of holes and padding in this struct. This >> patch reorders the members and shrinks the struct down to 80 bytes >> (from 136 bytes,

Re: [PATCH v4 11/11] pack-objects.h: reorder members to shrink struct object_entry

2018-03-16 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Previous patches leave lots of holes and padding in this struct. This > patch reorders the members and shrinks the struct down to 80 bytes > (from 136 bytes, before any field shrinking is done) with 16 bits to > spare (and a couple more in

[PATCH v4 11/11] pack-objects.h: reorder members to shrink struct object_entry

2018-03-16 Thread Nguyễn Thái Ngọc Duy
Previous patches leave lots of holes and padding in this struct. This patch reorders the members and shrinks the struct down to 80 bytes (from 136 bytes, before any field shrinking is done) with 16 bits to spare (and a couple more in in_pack_header_size when we really run out of bits).