Re: [PATCH v4 11/21] range-diff: add tests

2018-07-31 Thread Junio C Hamano
Stefan Beller writes: > On Mon, Jul 30, 2018 at 1:18 PM Junio C Hamano wrote: > >> > I already pushed an update to https://github.com/gitgitgadget/git/pull/1. >> >> Should I take "pushed to ... GGG" to mean "do not merge what you >> have to 'next' yet, as there will be an updated series (not >>

Re: [PATCH v4 11/21] range-diff: add tests

2018-07-30 Thread Stefan Beller
On Mon, Jul 30, 2018 at 1:18 PM Junio C Hamano wrote: > > I already pushed an update to https://github.com/gitgitgadget/git/pull/1. > > Should I take "pushed to ... GGG" to mean "do not merge what you > have to 'next' yet, as there will be an updated series (not > incremental) being prepared"?

Re: [PATCH v4 11/21] range-diff: add tests

2018-07-30 Thread Junio C Hamano
Johannes Schindelin writes: > On Sun, 22 Jul 2018, Eric Sunshine wrote: > >> On Sat, Jul 21, 2018 at 6:05 PM Thomas Rast via GitGitGadget >> wrote: >> > These are essentially lifted from https://github.com/trast/tbdiff, with >> > light touch-ups to account for the command now being names `git

Re: [PATCH v4 11/21] range-diff: add tests

2018-07-30 Thread Johannes Schindelin
Hi Eric, On Sun, 22 Jul 2018, Eric Sunshine wrote: > On Sat, Jul 21, 2018 at 6:05 PM Thomas Rast via GitGitGadget > wrote: > > These are essentially lifted from https://github.com/trast/tbdiff, with > > light touch-ups to account for the command now being names `git > > s/names/named/ Thanks.

Re: [PATCH v4 11/21] range-diff: add tests

2018-07-23 Thread Stefan Beller
> +test_expect_success 'simple B...C (unmodified)' ' > + git range-diff --no-color I wonder if we want to have tests for colors, too, eventually. (Feel free to push back on it or put it into the left over hashtag. But given how much time we (or I) spent discussing colors, this would be a

Re: [PATCH v4 11/21] range-diff: add tests

2018-07-21 Thread Eric Sunshine
On Sat, Jul 21, 2018 at 6:05 PM Thomas Rast via GitGitGadget wrote: > These are essentially lifted from https://github.com/trast/tbdiff, with > light touch-ups to account for the command now being names `git s/names/named/ > range-diff`. > > Apart from renaming `tbdiff` to `range-diff`, only

[PATCH v4 11/21] range-diff: add tests

2018-07-21 Thread Thomas Rast via GitGitGadget
From: Thomas Rast These are essentially lifted from https://github.com/trast/tbdiff, with light touch-ups to account for the command now being names `git range-diff`. Apart from renaming `tbdiff` to `range-diff`, only one test case needed to be adjusted: 11 - 'changed message'. The underlying