Re: [PATCH v4 12/35] serve: introduce git-serve

2018-03-13 Thread Brandon Williams
On 03/02, Junio C Hamano wrote: > Brandon Williams writes: > > > + Capabilities > > +~~ > > + > > +There are two different types of capabilities: normal capabilities, > > +which can be used to to convey information or alter the behavior of a > > +request, and

Re: [PATCH v4 12/35] serve: introduce git-serve

2018-03-13 Thread Brandon Williams
On 03/02, Junio C Hamano wrote: > Brandon Williams writes: > > +static int is_command(const char *key, struct protocol_capability > > **command) > > +{ > > + const char *out; > > + > > + if (skip_prefix(key, "command=", )) { > > + struct protocol_capability *cmd

Re: [PATCH v4 12/35] serve: introduce git-serve

2018-03-12 Thread Brandon Williams
On 03/01, Junio C Hamano wrote: > Brandon Williams writes: > > > Documentation/technical/protocol-v2.txt | 171 > > Unlike other things in Documentation/technical/, this is not listed > on TECH_DOCS list in Documentation/Makefile. Shouldn't it be? Yes it

Re: [PATCH v4 12/35] serve: introduce git-serve

2018-03-02 Thread Junio C Hamano
Brandon Williams writes: > + /* > + * Function queried to see if a capability should be advertised. > + * Optionally a value can be specified by adding it to 'value'. > + * If a value is added to 'value', the server will advertise this > + * capability

Re: [PATCH v4 12/35] serve: introduce git-serve

2018-03-02 Thread Junio C Hamano
Brandon Williams writes: > + Capabilities > +~~ > + > +There are two different types of capabilities: normal capabilities, > +which can be used to to convey information or alter the behavior of a > +request, and commands, which are the core actions that a client

Re: [PATCH v4 12/35] serve: introduce git-serve

2018-03-01 Thread Junio C Hamano
Brandon Williams writes: > Documentation/technical/protocol-v2.txt | 171 Unlike other things in Documentation/technical/, this is not listed on TECH_DOCS list in Documentation/Makefile. Shouldn't it be?

[PATCH v4 12/35] serve: introduce git-serve

2018-02-28 Thread Brandon Williams
Introduce git-serve, the base server for protocol version 2. Protocol version 2 is intended to be a replacement for Git's current wire protocol. The intention is that it will be a simpler, less wasteful protocol which can evolve over time. Protocol version 2 improves upon version 1 by