Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

On Mon, Dec 04, 2017 at 10:54:40PM +0100, Lars Schneider wrote: > > Better, IMHO, though I still think literally saying: > > > > hint: Waiting for your editor to exit... > > > > is the most accurate, which I think makes it clear that you must _exit_ > > your editor, not just save and close the

Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

> On 04 Dec 2017, at 22:42, Jeff King wrote: > > On Mon, Dec 04, 2017 at 10:31:15PM +0100, Lars Schneider wrote: > I would like to add "for your input" or "for you" to convey that Git is not waiting for the machine but for the user. "hint: Launched

Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

On Mon, Dec 04, 2017 at 10:31:15PM +0100, Lars Schneider wrote: > >> I would like to add "for your input" or "for you" to convey > >> that Git is not waiting for the machine but for the user. > >> > >>"hint: Launched editor. Waiting for your input..." > >> > >> Would that work for you? > >

Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

Jeff King writes: > On Sun, Dec 03, 2017 at 01:47:04PM +0100, Lars Schneider wrote: > >> I am on the fence here. I like consistency but I don't want to >> bother Git users. >> >> @Peff: Do you lean into either direction? Could you imagine that >> novice/regular users are

Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

> On 04 Dec 2017, at 18:32, Jeff King wrote: > > On Sun, Dec 03, 2017 at 01:47:04PM +0100, Lars Schneider wrote: > >> I am on the fence here. I like consistency but I don't want to >> bother Git users. >> >> @Peff: Do you lean into either direction? Could you imagine that >>

Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

> On 04 Dec 2017, at 18:26, Jeff King wrote: > > On Sun, Dec 03, 2017 at 05:39:10PM +0100, Lars Schneider wrote: > > + fprintf(stderr, _("hint: Waiting for your editor > input...")); I found "waiting for editor input" to be a funny way of

Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

On Sun, Dec 03, 2017 at 01:47:04PM +0100, Lars Schneider wrote: > I am on the fence here. I like consistency but I don't want to > bother Git users. > > @Peff: Do you lean into either direction? Could you imagine that > novice/regular users are bothered? (I don't expect experts to be > bothered

Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

On Sat, Dec 02, 2017 at 09:15:29PM -0800, Junio C Hamano wrote: > Jeff King writes: > > > I tried to think of ways this "show a message and then delete it" could > > go wrong. It should work OK with editors that just do curses-like > > things, taking over the terminal and then

Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

On Sun, Dec 03, 2017 at 05:39:10PM +0100, Lars Schneider wrote: > >>> + fprintf(stderr, _("hint: Waiting for your editor > >>> input...")); > >> I found "waiting for editor input" to be a funny way of saying this. I > >> input to the editor, the editor does not input to

Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

On Sat, Dec 02, 2017 at 09:15:49AM +0530, Kaartic Sivaraam wrote: > > Or given that the goal is really just making it clear that we've spawned > > an editor, something like "starting editor %s..." would work. > > There was already discussion related to the "continuous tense" used in the >

Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

On Sun, 2017-12-03 at 17:39 +0100, Lars Schneider wrote: > > On 02 Dec 2017, at 04:45, Kaartic Sivaraam > > wrote: > > > > On Friday 01 December 2017 11:59 PM, Jeff King wrote: > > > On Fri, Dec 01, 2017 at 01:52:14PM +0100, Lars Schneider wrote: > > > > > > > >

Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

> On 02 Dec 2017, at 04:45, Kaartic Sivaraam wrote: > > On Friday 01 December 2017 11:59 PM, Jeff King wrote: >> On Fri, Dec 01, 2017 at 01:52:14PM +0100, Lars Schneider wrote: >>> >>> Thanks for the review :-) >> Actually, I meant to bikeshed one part but forgot.

Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

> On 03 Dec 2017, at 06:15, Junio C Hamano wrote: > > Jeff King writes: > >> I tried to think of ways this "show a message and then delete it" could >> go wrong. It should work OK with editors that just do curses-like >> things, taking over the terminal and

Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

Jeff King writes: > I tried to think of ways this "show a message and then delete it" could > go wrong. It should work OK with editors that just do curses-like > things, taking over the terminal and then restoring it at the end. > ... I think that it is not worth to special-case

Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

On Friday 01 December 2017 11:59 PM, Jeff King wrote: On Fri, Dec 01, 2017 at 01:52:14PM +0100, Lars Schneider wrote: Thanks for the review :-) Actually, I meant to bikeshed one part but forgot. ;) + fprintf(stderr, _("hint: Waiting for your editor input...")); I

Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

On Fri, Dec 01, 2017 at 01:52:14PM +0100, Lars Schneider wrote: > > These are obviously the result of devils-advocate poking at the feature. > > I doubt any editor would end its output with a CR. But the first case is > > probably going to be common, especially for actual graphical editors. We >

Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

> On 30 Nov 2017, at 21:51, Jeff King wrote: > > On Wed, Nov 29, 2017 at 03:37:52PM +0100, lars.schnei...@autodesk.com wrote: > ... >> The standard advise() function is not used here as it would always add >> a newline which would make deleting the message harder. > > I tried to

Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

On Friday 01 December 2017 02:21 AM, Jeff King wrote: These are obviously the result of devils-advocate poking at the feature. I doubt any editor would end its output with a CR. But the first case is probably going to be common, especially for actual graphical editors. We know that emacsclient

Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

On Wed, Nov 29, 2017 at 03:37:52PM +0100, lars.schnei...@autodesk.com wrote: > No message is printed in a "dumb" terminal as it would not be possible > to remove the message after the editor returns. This should not be a > problem as this feature is targeted at novice Git users and they are >

[PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

From: Lars Schneider When a graphical GIT_EDITOR is spawned by a Git command that opens and waits for user input (e.g. "git rebase -i"), then the editor window might be obscured by other windows. The user may be left staring at the original Git terminal window without