Re: [PATCH v4 2/2] version-gen: fix versions

2013-10-13 Thread Felipe Contreras
On Mon, Oct 14, 2013 at 12:01 AM, Jonathan Nieder wrote: > Hi, > > David Aguilar wrote: >> Felipe Contreras wrote: > >>> Virtually all packaging guidelines would prefer 1.8.4~rc1, over >>> 1.8.4.rc1 or 1.8.4-rc1, so it makes sense to use that instead. >>> >>> In particular, the only packaging we

Re: [PATCH v4 2/2] version-gen: fix versions

2013-10-13 Thread Jonathan Nieder
Hi, David Aguilar wrote: > Felipe Contreras wrote: >> Virtually all packaging guidelines would prefer 1.8.4~rc1, over >> 1.8.4.rc1 or 1.8.4-rc1, so it makes sense to use that instead. >> >> In particular, the only packaging we provide, git.spec, generates a >> wrong version, because git-1.8.4 <

Re: [PATCH v4 2/2] version-gen: fix versions

2013-10-13 Thread Felipe Contreras
On Sun, Oct 13, 2013 at 4:56 PM, David Aguilar wrote: > On Sat, Oct 12, 2013 at 12:07 AM, Felipe Contreras > wrote: >> Virtually all packaging guidelines would prefer 1.8.4~rc1, over >> 1.8.4.rc1 or 1.8.4-rc1, so it makes sense to use that instead. >> >> In particular, the only packaging we provi

Re: [PATCH v4 2/2] version-gen: fix versions

2013-10-13 Thread David Aguilar
On Sat, Oct 12, 2013 at 12:07 AM, Felipe Contreras wrote: > Virtually all packaging guidelines would prefer 1.8.4~rc1, over > 1.8.4.rc1 or 1.8.4-rc1, so it makes sense to use that instead. > > In particular, the only packaging we provide, git.spec, generates a > wrong version, because git-1.8.4 <

[PATCH v4 2/2] version-gen: fix versions

2013-10-12 Thread Felipe Contreras
Virtually all packaging guidelines would prefer 1.8.4~rc1, over 1.8.4.rc1 or 1.8.4-rc1, so it makes sense to use that instead. In particular, the only packaging we provide, git.spec, generates a wrong version, because git-1.8.4 < git-1.8.4.rc1, changing to ~rc1 fixes the problem as it's considered