Re: [PATCH v4 3/3] untracked cache: fix entry invalidation

2015-08-25 Thread Junio C Hamano
David Turner writes: > On Wed, 2015-08-19 at 20:01 +0700, Nguyễn Thái Ngọc Duy wrote: >> First, the current code in untracked_cache_invalidate_path() is wrong >> because it can only handle paths "a" or "a/b", not "a/b/c" because >> lookup_untracked() only looks for entries directly under the give

Re: [PATCH v4 3/3] untracked cache: fix entry invalidation

2015-08-25 Thread David Turner
On Wed, 2015-08-19 at 20:01 +0700, Nguyễn Thái Ngọc Duy wrote: > First, the current code in untracked_cache_invalidate_path() is wrong > because it can only handle paths "a" or "a/b", not "a/b/c" because > lookup_untracked() only looks for entries directly under the given > directory. In the last c

[PATCH v4 3/3] untracked cache: fix entry invalidation

2015-08-19 Thread Nguyễn Thái Ngọc Duy
First, the current code in untracked_cache_invalidate_path() is wrong because it can only handle paths "a" or "a/b", not "a/b/c" because lookup_untracked() only looks for entries directly under the given directory. In the last case, it will look for the entry "b/c" in directory "a" instead. This me