Re: [PATCH v4 3/7] gc: add --keep-largest-pack option

2018-03-25 Thread Junio C Hamano
Duy Nguyen writes: >> This conflicts with master because of your own 7e1eeaa431 ("completion: >> use __gitcomp_builtin in _git_gc", 2018-02-09). I pushed out a >> avar-pclouds/gc-auto-keep-base-pack branch to github.com/avar/git which >> resolves it as: >> >> @@ -365,6

Re: [PATCH v4 3/7] gc: add --keep-largest-pack option

2018-03-24 Thread Duy Nguyen
On Sat, Mar 24, 2018 at 10:36 AM, Ævar Arnfjörð Bjarmason wrote: > > On Sat, Mar 24 2018, Nguyễn Thái Ngọc Duy wrote: > >> struct option builtin_gc_options[] = { >> OPT__QUIET(, N_("suppress progress reporting")), >> @@ -362,6 +390,8 @@ int cmd_gc(int argc,

Re: [PATCH v4 3/7] gc: add --keep-largest-pack option

2018-03-24 Thread Ævar Arnfjörð Bjarmason
On Sat, Mar 24 2018, Nguyễn Thái Ngọc Duy wrote: > struct option builtin_gc_options[] = { > OPT__QUIET(, N_("suppress progress reporting")), > @@ -362,6 +390,8 @@ int cmd_gc(int argc, const char **argv, const char > *prefix) > OPT_BOOL(0, "aggressive", , N_("be

[PATCH v4 3/7] gc: add --keep-largest-pack option

2018-03-24 Thread Nguyễn Thái Ngọc Duy
This adds a new repack mode that combines everything into a secondary pack, leaving the largest pack alone. This could help reduce memory pressure. On linux-2.6.git, valgrind massif reports 1.6GB heap in "pack all" case, and 535MB in "pack all except the base pack" case. We save roughly 1GB

[PATCH v4 3/7] gc: add --keep-largest-pack option

2018-03-24 Thread Nguyễn Thái Ngọc Duy
This adds a new repack mode that combines everything into a secondary pack, leaving the largest pack alone. This could help reduce memory pressure. On linux-2.6.git, valgrind massif reports 1.6GB heap in "pack all" case, and 535MB in "pack all except the base pack" case. We save roughly 1GB