Re: [PATCH v4 3/9] checkout.[ch]: move struct declaration into *.h

2018-06-01 Thread Ævar Arnfjörð Bjarmason
On Fri, Jun 01 2018, Junio C Hamano wrote: > Thomas Gummerer writes: > >> We seem to have plenty of structs defined in '.c' files, if they are >> only needed there. Its use also seems to be single purpose for the >> callback data, so I'm a bit puzzled how having this in a header file >>

Re: [PATCH v4 3/9] checkout.[ch]: move struct declaration into *.h

2018-05-31 Thread Junio C Hamano
Thomas Gummerer writes: > We seem to have plenty of structs defined in '.c' files, if they are > only needed there. Its use also seems to be single purpose for the > callback data, so I'm a bit puzzled how having this in a header file > instead of the .c file would be helpful? > > I feel like

Re: [PATCH v4 3/9] checkout.[ch]: move struct declaration into *.h

2018-05-31 Thread Thomas Gummerer
On 05/31, Ævar Arnfjörð Bjarmason wrote: > Move the tracking_name_data struct used in checkout.c into its > corresponding header file. This wasn't done in 7c85a87c54 ("checkout: > factor out functions to new lib file", 2017-11-26) when checkout.[ch] > were created, and is more consistent with the

[PATCH v4 3/9] checkout.[ch]: move struct declaration into *.h

2018-05-31 Thread Ævar Arnfjörð Bjarmason
Move the tracking_name_data struct used in checkout.c into its corresponding header file. This wasn't done in 7c85a87c54 ("checkout: factor out functions to new lib file", 2017-11-26) when checkout.[ch] were created, and is more consistent with the rest of the codebase. Signed-off-by: Ævar