On 10/10/2017 9:30 AM, Jeff King wrote:
On Tue, Oct 10, 2017 at 09:11:15AM -0400, Derrick Stolee wrote:
On 10/10/2017 8:56 AM, Junio C Hamano wrote:
Jeff King writes:
OK, I think that makes more sense. But note the p->num_objects thing I
mentioned. If I do:
git
On Tue, Oct 10, 2017 at 09:11:15AM -0400, Derrick Stolee wrote:
> On 10/10/2017 8:56 AM, Junio C Hamano wrote:
> > Jeff King writes:
> >
> > > OK, I think that makes more sense. But note the p->num_objects thing I
> > > mentioned. If I do:
> > >
> > >git pack-objects
On 10/10/2017 8:56 AM, Junio C Hamano wrote:
Jeff King writes:
OK, I think that makes more sense. But note the p->num_objects thing I
mentioned. If I do:
git pack-objects .git/objects/pack/pack num_objects)
return;
Technically that also covers open_pack_index()
On Tue, Oct 10, 2017 at 09:56:38PM +0900, Junio C Hamano wrote:
> Jeff King writes:
>
> > OK, I think that makes more sense. But note the p->num_objects thing I
> > mentioned. If I do:
> >
> > git pack-objects .git/objects/pack/pack >
> > then I have a pack with zero objects,
Jeff King writes:
> OK, I think that makes more sense. But note the p->num_objects thing I
> mentioned. If I do:
>
> git pack-objects .git/objects/pack/pack
> then I have a pack with zero objects, which I think we'd similarly want
> to return early from. I.e., I think we need:
On Tue, Oct 10, 2017 at 08:16:27AM -0400, Derrick Stolee wrote:
> > > + mad->init_len = 0;
> > > + if (!match) {
> > > + nth_packed_object_oid(, p, first);
> > > + extend_abbrev_len(, mad);
> > If we have zero objects in the pack, what would nth_packed_object_oid()
> > be
On 10/9/2017 9:49 AM, Jeff King wrote:
On Sun, Oct 08, 2017 at 02:49:42PM -0400, Derrick Stolee wrote:
@@ -505,6 +506,65 @@ static int extend_abbrev_len(const struct object_id *oid,
void *cb_data)
return 0;
}
+static void find_abbrev_len_for_pack(struct packed_git *p,
+
On Sun, Oct 08, 2017 at 02:49:42PM -0400, Derrick Stolee wrote:
> @@ -505,6 +506,65 @@ static int extend_abbrev_len(const struct object_id
> *oid, void *cb_data)
> return 0;
> }
>
> +static void find_abbrev_len_for_pack(struct packed_git *p,
> + struct
Minimize OID comparisons during disambiguatiosn of packfile OIDs.
Teach git to use binary search with the full OID to find the object's
position (or insertion position, if not present) in the pack-index.
The object before and immediately after (or the one at the insertion
position) give the
9 matches
Mail list logo