On Sat, Mar 21, 2015 at 1:46 AM, Paul Tan pyoka...@gmail.com wrote:
On Thu, Mar 19, 2015 at 3:26 AM, Eric Sunshine sunsh...@sunshineco.com
wrote:
On Wed, Mar 18, 2015 at 3:04 AM, Paul Tan pyoka...@gmail.com wrote:
diff --git a/t/t0302-credential-store.sh b/t/t0302-credential-store.sh
index
Hi,
On Thu, Mar 19, 2015 at 9:35 PM, Matthieu Moy
matthieu@grenoble-inp.fr wrote:
Eric Sunshine sunsh...@sunshineco.com writes:
I also tend to favor adding failure tests which are flipped to
success when appropriate, however, as this is an entirely new
feature, this approach may be
Hi,
On Thu, Mar 19, 2015 at 3:26 AM, Eric Sunshine sunsh...@sunshineco.com wrote:
On Wed, Mar 18, 2015 at 3:04 AM, Paul Tan pyoka...@gmail.com wrote:
diff --git a/t/t0302-credential-store.sh b/t/t0302-credential-store.sh
index f61b40c..5b0a666 100755
--- a/t/t0302-credential-store.sh
+++
Eric Sunshine sunsh...@sunshineco.com writes:
I also tend to favor adding failure tests which are flipped to
success when appropriate, however, as this is an entirely new
feature, this approach may be unsuitable (and perhaps overkill).
I can buy the overkill, but not unsuitable. Even for new
On Wed, Mar 18, 2015 at 3:26 PM, Eric Sunshine sunsh...@sunshineco.com wrote:
On Wed, Mar 18, 2015 at 3:04 AM, Paul Tan pyoka...@gmail.com wrote:
t0302 now tests git-credential-store's support for the XDG user-specific
configuration file $XDG_CONFIG_HOME/git/credentials. Specifically:
---
Similarly to the merge doc and code, I personally prefer seeing code
and tests in the same patch.
Actually, my preference goes for a first patch that introduces the tests
with test_expect_failure for things that are not yet implemented (and
you can check that tests do not pass yet before you
On Wed, Mar 18, 2015 at 3:04 AM, Paul Tan pyoka...@gmail.com wrote:
t0302 now tests git-credential-store's support for the XDG user-specific
configuration file $XDG_CONFIG_HOME/git/credentials. Specifically:
---
The previous version can be found at [1].
[1]
t0302 now tests git-credential-store's support for the XDG user-specific
configuration file $XDG_CONFIG_HOME/git/credentials. Specifically:
* Ensure that the XDG file is strictly opt-in. It should not be created
by git at all times if it does not exist.
* Conversely, if the XDG file exists,
On Wed, Mar 18, 2015 at 12:41 PM, Matthieu Moy
matthieu@grenoble-inp.fr wrote:
Similarly to the merge doc and code, I personally prefer seeing code
and tests in the same patch.
In this case, the patch introducing the tests is already quite long
and intricate, almost to the point of being a
9 matches
Mail list logo
