Re: [PATCH v4 4/4] t7800: run both builtin and scripted difftool, for now

2017-01-09 Thread Junio C Hamano
Johannes Schindelin writes: > And the most important point is that we do all of this only during a > hopefully brief period in time that is mostly spent on reviewing the code > and finding serious bugs and fixing them. You seem to misunderstand the purpose of the code review. We indeed spot b

Re: [PATCH v4 4/4] t7800: run both builtin and scripted difftool, for now

2017-01-08 Thread Johannes Schindelin
Hi Junio, On Sun, 8 Jan 2017, Junio C Hamano wrote: > Johannes Schindelin writes: > > > This is uglier than a simple > > > > touch "$GIT_EXEC_PATH/use-builtin-difftool" > > > > of course. But oh well. > > That is totally irrelevant. > > The more important point is that we do the same se

Re: [PATCH v4 4/4] t7800: run both builtin and scripted difftool, for now

2017-01-08 Thread Junio C Hamano
Johannes Schindelin writes: > This is uglier than a simple > > touch "$GIT_EXEC_PATH/use-builtin-difftool" > > of course. But oh well. That is totally irrelevant. The more important point is that we do the same set of tests so instead of running just one, we run BOTH. If we did a bit m

[PATCH v4 4/4] t7800: run both builtin and scripted difftool, for now

2017-01-02 Thread Johannes Schindelin
This is uglier than a simple touch "$GIT_EXEC_PATH/use-builtin-difftool" of course. But oh well. Signed-off-by: Johannes Schindelin --- This patch implements the good ole' cross-validation technique (also known as "GitHub Scientist") that I already used for my r