Re: [PATCH v5] mru: Replace mru.[ch] with list.h implementation

On Mon, Jan 22, 2018 at 07:37:01AM +, Eric Wong wrote: > > --- a/packfile.c > > +++ b/packfile.c > > @@ -859,9 +859,8 @@ static void prepare_packed_git_mru(void) > > { > > struct packed_git *p; > > > > - mru_clear(_git_mru); > > But the removed mru_clear needs to be replaced with: >

Re: [PATCH v5] mru: Replace mru.[ch] with list.h implementation

Gargi Sharma wrote: > 7 files changed, 15 insertions(+), 86 deletions(-) Thanks! I like the code reduction and increased use of list.h Were you able to finish running the test suite? I wasn't :< > -void mru_clear(struct mru *head) > -{ > - struct list_head *pos; > -

[PATCH v5] mru: Replace mru.[ch] with list.h implementation

Replace the custom calls to mru.[ch] with calls to list.h. This patch is the final step in removing the mru API completely and inlining the logic. This patch leads to significant code reduction and the mru API hence, is not a useful abstraction anymore. Signed-off-by: Gargi Sharma