Re: [PATCH v5] pack-objects mru

2016-08-11 Thread Jeff King
On Thu, Aug 11, 2016 at 08:11:33AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > So considering "--depth" as a space-saving measure for --aggressive does > > not seem that effective. But it feels weird to quietly drop actions > > people might have done with previous aggressive runs. >

Re: [PATCH v5] pack-objects mru

2016-08-11 Thread Junio C Hamano
Jeff King writes: > So considering "--depth" as a space-saving measure for --aggressive does > not seem that effective. But it feels weird to quietly drop actions > people might have done with previous aggressive runs. That argument cuts both ways, doesn't it? If the user explicitly asks to use

Re: [PATCH v5] pack-objects mru

2016-08-11 Thread Jeff King
On Thu, Aug 11, 2016 at 05:20:30AM -0400, Jeff King wrote: > Here it is. It ended up needing a few preparatory patches. > > [1/4]: provide an initializer for "struct object_info" > [2/4]: sha1_file: make packed_object_info public > [3/4]: pack-objects: break delta cycles before delta-search

[PATCH v5] pack-objects mru

2016-08-11 Thread Jeff King
On Thu, Aug 11, 2016 at 02:57:51AM -0400, Jeff King wrote: > > One thing to be careful of is that there are more things this > > drop_reused_delta() should be doing. But I looked through the rest of > > check_object() and could not find anything else. > > Argh, I spoke too soon. > > It is true t