Re: [PATCH v5 0/3] interactive git clean

2013-05-06 Thread Matthieu Moy
Eric Sunshine sunsh...@sunshineco.com writes: The pattern [y] will match file named 'y'. It probably is unusual for files named 'y', 'n', etc. to exist in the top-level directory, but the gitignore patterns already provide an escape hatch for these unusual cases. But how does the user know

Re: [PATCH v5 0/3] interactive git clean

2013-05-06 Thread Eric Sunshine
Hi Matthieu, On Mon, May 6, 2013 at 3:58 AM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Eric Sunshine sunsh...@sunshineco.com writes: The pattern [y] will match file named 'y'. It probably is unusual for files named 'y', 'n', etc. to exist in the top-level directory, but the gitignore

Re: [PATCH v5 0/3] interactive git clean

2013-05-05 Thread Eric Sunshine
On Fri, May 3, 2013 at 9:06 PM, Jiang Xin worldhello@gmail.com wrote: 2013/5/3 Eric Sunshine sunsh...@sunshineco.com: More generally, is this sort of modal edit mode desirable and convenient? Can the edit operation be combined with the top-level prompt? For example: % git clean -i

Re: [PATCH v5 0/3] interactive git clean

2013-05-03 Thread Eric Sunshine
Usability observations below... On Thu, May 2, 2013 at 11:49 PM, Jiang Xin worldhello@gmail.com wrote: The interactive git clean combines `git clean -n` and `git clean -f` together to do safe cleaning, and has more features. First it displays what would be removed in columns (so that you

Re: [PATCH v5 0/3] interactive git clean

2013-05-03 Thread Junio C Hamano
Jiang Xin worldhello@gmail.com writes: The interactive git clean combines `git clean -n` and `git clean -f` together to do safe cleaning, and has more features. First it displays what would be removed in columns (so that you can see them all in one screen). The user must confirm before

Re: [PATCH v5 0/3] interactive git clean

2013-05-03 Thread Jiang Xin
2013/5/3 Eric Sunshine sunsh...@sunshineco.com: WARNING: The following items will be removed permanently. Press y WARNING: to start cleaning, and press n to abort the cleaning. WARNING: You can also enter the edit mode, and select items WARNING: to be excluded from the

[PATCH v5 0/3] interactive git clean

2013-05-02 Thread Jiang Xin
The interactive git clean combines `git clean -n` and `git clean -f` together to do safe cleaning, and has more features. First it displays what would be removed in columns (so that you can see them all in one screen). The user must confirm before actually cleaning. WARNING: The following