Re: [PATCH v5 01/15] fast-export: avoid importing blob marks

2012-11-12 Thread Junio C Hamano
Jeff King p...@peff.net writes: Major issue: echo -n is still not portable. Could we simply use touch marks-cur touch marks-new Yes, echo -n is definitely not portable. Our preferred way of creating an empty file is just file. Yes. And it is misleading to use touch in this case;

Re: [PATCH v5 01/15] fast-export: avoid importing blob marks

2012-11-11 Thread Torsten Bögershausen
On 11.11.12 14:59, Felipe Contreras wrote: test_expect_success 'test biridectionality' ' + echo -n marks-cur + echo -n marks-new Unless I messed up the patch: Minor issue: still a typo biridectionality Major issue: echo -n is still not portable. Could we simply use touch