Re: [PATCH v5 04/13] csum-file: add CSUM_KEEP_OPEN flag

Derrick Stolee writes: >> close_commit_graph(); >> >> And after writing all data out (oh by the way, why aren't we passing >> commit_graph instance around and instead relying on a file-scope >> static global?)... > > Yeah, we should remove the global dependence. Is this a

Re: [PATCH v5 04/13] csum-file: add CSUM_KEEP_OPEN flag

On 3/13/2018 5:42 PM, Junio C Hamano wrote: Derrick Stolee writes: On 2/26/2018 9:32 PM, Derrick Stolee wrote: This patch is new to the series due to the interactions with the lockfile API and the hashfile API. I need to ensure the hashfile writes the hash value at the end

Re: [PATCH v5 04/13] csum-file: add CSUM_KEEP_OPEN flag

Derrick Stolee writes: > On 2/26/2018 9:32 PM, Derrick Stolee wrote: >> This patch is new to the series due to the interactions with the lockfile API >> and the hashfile API. I need to ensure the hashfile writes the hash value at >> the end of the file, but keep the file

Re: [PATCH v5 04/13] csum-file: add CSUM_KEEP_OPEN flag

On 2/26/2018 9:32 PM, Derrick Stolee wrote: This patch is new to the series due to the interactions with the lockfile API and the hashfile API. I need to ensure the hashfile writes the hash value at the end of the file, but keep the file descriptor open so the lock is valid. I welcome any

[PATCH v5 04/13] csum-file: add CSUM_KEEP_OPEN flag

This patch is new to the series due to the interactions with the lockfile API and the hashfile API. I need to ensure the hashfile writes the hash value at the end of the file, but keep the file descriptor open so the lock is valid. I welcome any susggestions to this patch or to the way I use it