Re: [PATCH v5 1/2] config: document git config getter return value

2018-08-06 Thread Han-Wen Nienhuys
On Mon, Aug 6, 2018 at 6:32 PM Junio C Hamano wrote: > patch and queue it on its own merit (not that I think the other one > is not yet good enough---I haven't even looked at it yet ;-). I discovered that emacs tabify will happily also add tabs in the middle of the line, which breaks in the case

Re: [PATCH v5 1/2] config: document git config getter return value

2018-08-06 Thread Junio C Hamano
Han-Wen Nienhuys writes: > Signed-off-by: Han-Wen Nienhuys > --- > config.h | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) I think this is good (I read all the comments on v3 and v4 in the archive before I said this). Let's split it off from the other patch and queue it on its

[PATCH v5 1/2] config: document git config getter return value

2018-08-06 Thread Han-Wen Nienhuys
Signed-off-by: Han-Wen Nienhuys --- config.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/config.h b/config.h index bb2f506b27..183b31ebf4 100644 --- a/config.h +++ b/config.h @@ -188,9 +188,14 @@ struct config_set { extern void git_configset_init(struct