Re: [PATCH v5 1/4] add -p: select individual hunk lines

2018-07-27 Thread Junio C Hamano
Phillip Wood writes: > On 26/07/18 20:36, Junio C Hamano wrote: >> Phillip Wood writes: >> >>> +sub label_hunk_lines { >>> + my $hunk = shift; >>> + my $text = $hunk->{TEXT}; >>> + my (@line_flags, @lines); >>> + my ($block, $label, $last_mode) = (0, 0, ''); >>> + for my $line

Re: [PATCH v5 1/4] add -p: select individual hunk lines

2018-07-27 Thread Phillip Wood
On 26/07/18 20:36, Junio C Hamano wrote: > Phillip Wood writes: > >> +sub label_hunk_lines { >> +my $hunk = shift; >> +my $text = $hunk->{TEXT}; >> +my (@line_flags, @lines); >> +my ($block, $label, $last_mode) = (0, 0, ''); >> +for my $line (1..$#{$text}) { > > $text is a

Re: [PATCH v5 1/4] add -p: select individual hunk lines

2018-07-26 Thread Junio C Hamano
Phillip Wood writes: > +sub label_hunk_lines { > + my $hunk = shift; > + my $text = $hunk->{TEXT}; > + my (@line_flags, @lines); > + my ($block, $label, $last_mode) = (0, 0, ''); > + for my $line (1..$#{$text}) { $text is a ref to an array so @$text is the whole thing,

[PATCH v5 1/4] add -p: select individual hunk lines

2018-07-26 Thread Phillip Wood
From: Phillip Wood When I end up editing hunks it is almost always because I want to stage a subset of the lines in the hunk. Doing this by editing the hunk is inconvenient and error prone (especially so if the patch is going to be reversed before being applied). Instead offer an option for add