Re: [PATCH v5 1/5] stash: improve option parsing test coverage

2018-04-09 Thread Johannes Schindelin
Hi Paul, On Sat, 7 Apr 2018, Paul-Sebastian Ungureanu wrote: > On 06.04.2018 16:06, Johannes Schindelin wrote: > > > + git stash clear && > > > + test_when_finished "git reset --hard HEAD" && > > > + echo foo >file2 && > > > + git stash && > > > + echo bar >file2 && > > > + git stash && > > > +

Re: [PATCH v5 1/5] stash: improve option parsing test coverage

2018-04-06 Thread Paul-Sebastian Ungureanu
On 06.04.2018 16:06, Johannes Schindelin wrote: + git stash clear && + test_when_finished "git reset --hard HEAD" && + echo foo >file2 && + git stash && + echo bar >file2 && + git stash && + test-chmtime =123456789 file2 && + for type in apply pop

Re: [PATCH v5 1/5] stash: improve option parsing test coverage

2018-04-06 Thread Johannes Schindelin
Hi Joel, On Wed, 4 Apr 2018, Joel Teichroeb wrote: > In preparation for converting the stash command incrementally to > a builtin command, this patch improves test coverage of the option > parsing. Both for having too many parameters, or too few. Very good. > Signed-off-by: Joel Teichroeb

[PATCH v5 1/5] stash: improve option parsing test coverage

2018-04-04 Thread Joel Teichroeb
In preparation for converting the stash command incrementally to a builtin command, this patch improves test coverage of the option parsing. Both for having too many parameters, or too few. Signed-off-by: Joel Teichroeb --- t/t3903-stash.sh | 35