Re: [PATCH v5 16/16] merge-recursive: flush output buffer even when erroring out

2016-08-01 Thread Junio C Hamano
Johannes Schindelin writes: >> This is of course a good change, but we need to assume that no >> further output is made from the remainder of the function for the >> change in the next hunk to remove the existing flush to be correct. > ... > But you made me realize that I cannot simply *move* the

Re: [PATCH v5 16/16] merge-recursive: flush output buffer even when erroring out

2016-08-01 Thread Johannes Schindelin
Hi Junio, On Wed, 27 Jul 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > diff --git a/merge-recursive.c b/merge-recursive.c > > index a16b150..66e93e0 100644 > > --- a/merge-recursive.c > > +++ b/merge-recursive.c > > @@ -2069,6 +2069,7 @@ int merge_recursive(struct merge_option

Re: [PATCH v5 16/16] merge-recursive: flush output buffer even when erroring out

2016-07-27 Thread Junio C Hamano
Johannes Schindelin writes: > diff --git a/merge-recursive.c b/merge-recursive.c > index a16b150..66e93e0 100644 > --- a/merge-recursive.c > +++ b/merge-recursive.c > @@ -2069,6 +2069,7 @@ int merge_recursive(struct merge_options *o, > o->ancestor = "merged common ancestors"; > clean

[PATCH v5 16/16] merge-recursive: flush output buffer even when erroring out

2016-07-26 Thread Johannes Schindelin
Ever since 66a155b (Enable output buffering in merge-recursive., 2007-01-14), we had a problem: When the merge failed in a fatal way, all regular output was swallowed because we called die() and did not get a chance to drain the output buffers. To fix this, several modifications were necessary: -