Re: [PATCH v5 2/3] upload-pack: prepare to extend allow-tip-sha1-in-want

2015-05-22 Thread Fredrik Medley
2015-05-22 0:07 GMT+02:00 Junio C Hamano gits...@pobox.com: Fredrik Medley fredrik.med...@gmail.com writes: To allow future extensions, e.g. allowing non-tip sha1, replace the boolean allow_tip_sha1_in_want variable with the flag-style allow_request_with_bare_object_name variable.

Re: [PATCH v5 2/3] upload-pack: prepare to extend allow-tip-sha1-in-want

2015-05-22 Thread Junio C Hamano
Fredrik Medley fredrik.med...@gmail.com writes: +#define ALLOW_TIP_SHA1 01 +static int allow_unadvertised_object_request; It is better to use unsigned int for these bit masks, as we are not interested in the top-most bit getting special-cased by using a signed type. I'll amend this

[PATCH v5 2/3] upload-pack: prepare to extend allow-tip-sha1-in-want

2015-05-21 Thread Fredrik Medley
To allow future extensions, e.g. allowing non-tip sha1, replace the boolean allow_tip_sha1_in_want variable with the flag-style allow_request_with_bare_object_name variable. Signed-off-by: Fredrik Medley fredrik.med...@gmail.com --- fetch-pack.c | 9 ++--- upload-pack.c | 20

Re: [PATCH v5 2/3] upload-pack: prepare to extend allow-tip-sha1-in-want

2015-05-21 Thread Junio C Hamano
Fredrik Medley fredrik.med...@gmail.com writes: To allow future extensions, e.g. allowing non-tip sha1, replace the boolean allow_tip_sha1_in_want variable with the flag-style allow_request_with_bare_object_name variable. Signed-off-by: Fredrik Medley fredrik.med...@gmail.com ---