Re: [PATCH v5 3/5] pseudorefs: create and use pseudoref update and delete functions

2015-08-11 Thread Junio C Hamano
Junio C Hamano writes: > David Turner writes: > >> On Fri, 2015-07-31 at 16:40 -0700, Stefan Beller wrote: >>> I am sorry for being late to the review, I looked into coverity today as Duy >>> bugged me to fix the memory allocation stuff[1] >> >> Thanks. Junio, can you pleas substitute the attach

Re: [PATCH v5 3/5] pseudorefs: create and use pseudoref update and delete functions

2015-08-11 Thread David Turner
On Tue, 2015-08-11 at 15:47 -0700, Junio C Hamano wrote: > Junio C Hamano writes: > > > David Turner writes: > > > >> On Fri, 2015-07-31 at 16:40 -0700, Stefan Beller wrote: > >>> I am sorry for being late to the review, I looked into coverity today as > >>> Duy > >>> bugged me to fix the memor

Re: [PATCH v5 3/5] pseudorefs: create and use pseudoref update and delete functions

2015-08-11 Thread Junio C Hamano
David Turner writes: > On Fri, 2015-07-31 at 16:40 -0700, Stefan Beller wrote: >> I am sorry for being late to the review, I looked into coverity today as Duy >> bugged me to fix the memory allocation stuff[1] > > Thanks. Junio, can you pleas substitute the attached patch instead? No. The topic

Re: [PATCH v5 3/5] pseudorefs: create and use pseudoref update and delete functions

2015-08-11 Thread David Turner
On Fri, 2015-07-31 at 16:40 -0700, Stefan Beller wrote: > I am sorry for being late to the review, I looked into coverity today as Duy > bugged me to fix the memory allocation stuff[1] Thanks. Junio, can you pleas substitute the attached patch instead? It addresses Stefan's issues. If you prefe

Re: [PATCH v5 3/5] pseudorefs: create and use pseudoref update and delete functions

2015-07-31 Thread Stefan Beller
I am sorry for being late to the review, I looked into coverity today as Duy bugged me to fix the memory allocation stuff[1] [1] $gmane/275046 On Thu, Jul 30, 2015 at 11:06 PM, David Turner wrote: > + > + if (old_sha1) { > + unsigned char actual_old_sha1[20]; > +

[PATCH v5 3/5] pseudorefs: create and use pseudoref update and delete functions

2015-07-30 Thread David Turner
Pseudorefs should not be updated through the ref transaction API, because alternate ref backends still need to store pseudorefs in GIT_DIR (instead of wherever they store refs). Instead, change update_ref and delete_ref to call pseudoref-specific functions. Signed-off-by: David Turner --- refs.