Re: [PATCH v5 4/4] builtin/branch: strip refs/heads/ using skip_prefix

2017-12-08 Thread Kaartic Sivaraam
On Friday 08 December 2017 04:44 AM, Junio C Hamano wrote: Junio C Hamano writes: Somehow this fell underneath my radar horizon. I see v4 and v5 of 4/4 but do not seem to find 1-3/4. Is this meant to be a standalone patch, or am I expected to already have 1-3 that we

Re: [PATCH v5 4/4] builtin/branch: strip refs/heads/ using skip_prefix

2017-12-07 Thread Junio C Hamano
Junio C Hamano writes: > SZEDER Gábor writes: > >> On Fri, Dec 1, 2017 at 6:59 AM, Kaartic Sivaraam >> wrote: >>> Sorry, missed a ';' in v4. >>> >>> The surprising thing I discovered in the TravisCI build for v4 >>> was that

Re: [PATCH v5 4/4] builtin/branch: strip refs/heads/ using skip_prefix

2017-12-07 Thread Junio C Hamano
SZEDER Gábor writes: > On Fri, Dec 1, 2017 at 6:59 AM, Kaartic Sivaraam > wrote: >> Sorry, missed a ';' in v4. >> >> The surprising thing I discovered in the TravisCI build for v4 >> was that apart from the 'Documentation' build the 'Static

Re: [PATCH v5 4/4] builtin/branch: strip refs/heads/ using skip_prefix

2017-12-03 Thread SZEDER Gábor
On Fri, Dec 1, 2017 at 6:59 AM, Kaartic Sivaraam wrote: > Sorry, missed a ';' in v4. > > The surprising thing I discovered in the TravisCI build for v4 > was that apart from the 'Documentation' build the 'Static Analysis' > build passed, with the following output, > >

[PATCH v5 4/4] builtin/branch: strip refs/heads/ using skip_prefix

2017-11-30 Thread Kaartic Sivaraam
Instead of hard-coding the offset strlen("refs/heads/") to skip the prefix "refs/heads/" use the skip_prefix() function which is more communicative and verifies that the string actually starts with that prefix. Signed-off-by: Kaartic Sivaraam --- Sorry, missed a ';'