Re: [PATCH v5 4/6] ref-filter: change parsing function error handling

2018-03-23 Thread Оля Тележная
2018-03-21 23:36 GMT+03:00 Junio C Hamano : > Olga Telezhnaya writes: > >> @@ -2144,13 +2151,15 @@ int format_ref_array_item(struct ref_array_item >> *info, >> >> for (cp = format->format; *cp && (sp = find_next(cp)); cp = ep + 1) { >>

Re: [PATCH v5 4/6] ref-filter: change parsing function error handling

2018-03-21 Thread Junio C Hamano
Olga Telezhnaya writes: > @@ -2144,13 +2151,15 @@ int format_ref_array_item(struct ref_array_item *info, > > for (cp = format->format; *cp && (sp = find_next(cp)); cp = ep + 1) { > struct atom_value *atomv; > + int pos; > >

[PATCH v5 4/6] ref-filter: change parsing function error handling

2018-03-21 Thread Olga Telezhnaya
Continue removing die() calls from ref-filter formatting logic, so that it could be used by other commands. Change the signature of parse_ref_filter_atom() by adding strbuf parameter for error message. The function returns the position in the used_atom[] array (as before) for the given atom, or