Re: [PATCH v5 5/8] branch: drop non-commit error reporting

2015-09-21 Thread Karthik Nayak
On Mon, Sep 21, 2015 at 3:50 PM, Karthik Nayak wrote: > On Mon, Sep 21, 2015 at 12:46 AM, Matthieu Moy > wrote: >> Karthik Nayak writes: >> >>> Remove the error reporting variable to make the code easier to port >>> over to using ref-filter APIs. This variable >> >> (it's not just a variable, it

Re: [PATCH v5 5/8] branch: drop non-commit error reporting

2015-09-21 Thread Karthik Nayak
On Mon, Sep 21, 2015 at 12:46 AM, Matthieu Moy wrote: > Karthik Nayak writes: > >> Remove the error reporting variable to make the code easier to port >> over to using ref-filter APIs. This variable > > (it's not just a variable, it's also a message on the output) > >> is not required as in ref-f

Re: [PATCH v5 5/8] branch: drop non-commit error reporting

2015-09-20 Thread Matthieu Moy
Karthik Nayak writes: > Remove the error reporting variable to make the code easier to port > over to using ref-filter APIs. This variable (it's not just a variable, it's also a message on the output) > is not required as in ref-filter we already check for possible errors > and report them. Yo

[PATCH v5 5/8] branch: drop non-commit error reporting

2015-09-20 Thread Karthik Nayak
Remove the error reporting variable to make the code easier to port over to using ref-filter APIs. This variable is not required as in ref-filter we already check for possible errors and report them. Based-on-patch-by: Jeff King Mentored-by: Christian Couder Mentored-by: Matthieu Moy Signed-off