Jeff King writes:
> Out of curiosity, do you frequently test with GETTEXT_POISON, or did you
> just guess at a potential problem after reading the tests? Proper use
> of test_i18ncmp is definitely something we ought to be looking for
> during review, but I confess it's something
On Tue, Oct 03, 2017 at 03:24:41PM +0900, Junio C Hamano wrote:
> Jeff King writes:
>
> > Since that's the only thing I noticed, let's hold off on a reroll for
> > the moment to see if there are any more comments (and I won't be
> > surprised if Junio just picks it up with the
Jeff King writes:
> Since that's the only thing I noticed, let's hold off on a reroll for
> the moment to see if there are any more comments (and I won't be
> surprised if Junio just picks it up with the tweak, but we'll see).
>
> Please do make sure that "make test" runs clean
On Mon, Oct 02, 2017 at 09:15:00PM +0900, Junio C Hamano wrote:
> Junio C Hamano writes:
>
> > Thanks. t6300 seems to show that %(contents:trailers:unfold) does
> > not quite work, among other things.
> >
> > https://travis-ci.org/git/git/jobs/282126607#L3658
> >
> > I
Junio C Hamano writes:
> Thanks. t6300 seems to show that %(contents:trailers:unfold) does
> not quite work, among other things.
>
> https://travis-ci.org/git/git/jobs/282126607#L3658
>
> I didn't have a chance to look into it myself.
Peff's "oops, your logic is backwards"
Taylor Blau writes:
> Attached is the sixth revision of my patch-set "Support %(trailers)
> arguments in for-each-ref(1)".
>
> In includes the following changes since v5:
>
> * Added an additional patch to change t4205 to harden `unfold()`
> against multi-line trailer
On Sun, Oct 01, 2017 at 10:23:26PM -0700, Taylor Blau wrote:
> Attached is the sixth revision of my patch-set "Support %(trailers)
> arguments in for-each-ref(1)".
>
> In includes the following changes since v5:
>
> * Added an additional patch to change t4205 to harden `unfold()`
>
Hi,
Attached is the sixth revision of my patch-set "Support %(trailers)
arguments in for-each-ref(1)".
In includes the following changes since v5:
* Added an additional patch to change t4205 to harden `unfold()`
against multi-line trailer folding.
* Added a missing parameter call in
8 matches
Mail list logo