Re: [PATCH v6 03/42] refs.c: add a strbuf argument to ref_transaction_commit for error logging

Thanks. Comment added and whitespace fixed. On Tue, May 13, 2014 at 4:10 PM, Jonathan Nieder jrnie...@gmail.com wrote: Ronnie Sahlberg wrote: Add a strbuf argument to _commit so that we can pass an error string back to the caller. So that we can do error logging from the caller instead of

Re: [PATCH v6 03/42] refs.c: add a strbuf argument to ref_transaction_commit for error logging

Ronnie Sahlberg wrote: Add a strbuf argument to _commit so that we can pass an error string back to the caller. So that we can do error logging from the caller instead of from _commit. Longer term plan is to first convert all callers to use onerr==QUIET_ON_ERR and craft any log messages

[PATCH v6 03/42] refs.c: add a strbuf argument to ref_transaction_commit for error logging

Add a strbuf argument to _commit so that we can pass an error string back to the caller. So that we can do error logging from the caller instead of from _commit. Longer term plan is to first convert all callers to use onerr==QUIET_ON_ERR and craft any log messages from the callers themselves and