Re: [PATCH v6 05/15] sequencer: introduce the `merge` command

2018-04-19 Thread Johannes Schindelin
Hi Phillip, On Sat, 14 Apr 2018, Johannes Schindelin wrote: > On Fri, 13 Apr 2018, Phillip Wood wrote: > > > On 13/04/18 11:12, Phillip Wood wrote: > > > @@ -3030,7 +3029,8 @@ static int pick_commits(struct todo_list > > > *todo_list, struct replay_opts *opts) > > > return

Re: [PATCH v6 05/15] sequencer: introduce the `merge` command

2018-04-18 Thread Phillip Wood
On 14/04/18 01:51, Johannes Schindelin wrote: > Hi Phillip, > > On Fri, 13 Apr 2018, Phillip Wood wrote: > >> On 13/04/18 11:12, Phillip Wood wrote: >>> @@ -3030,7 +3029,8 @@ static int pick_commits(struct todo_list *todo_list, >>> struct replay_opts *opts) >>> return

Re: [PATCH v6 05/15] sequencer: introduce the `merge` command

2018-04-13 Thread Johannes Schindelin
Hi Phillip, On Fri, 13 Apr 2018, Phillip Wood wrote: > On 13/04/18 11:12, Phillip Wood wrote: > > @@ -3030,7 +3029,8 @@ static int pick_commits(struct todo_list *todo_list, > > struct replay_opts *opts) > > return error(_("unknown command %d"), item->command); > > > >

Re: [PATCH v6 05/15] sequencer: introduce the `merge` command

2018-04-13 Thread Phillip Wood
On 13/04/18 11:12, Phillip Wood wrote: > On 10/04/18 13:29, Johannes Schindelin wrote: >> +static int do_merge(struct commit *commit, const char *arg, int arg_len, >> +int flags, struct replay_opts *opts) >> +{ >> +int run_commit_flags = (flags & TODO_EDIT_MERGE_MSG) ? >> +

Re: [PATCH v6 05/15] sequencer: introduce the `merge` command

2018-04-13 Thread Phillip Wood
On 10/04/18 13:29, Johannes Schindelin wrote: > +static int do_merge(struct commit *commit, const char *arg, int arg_len, > + int flags, struct replay_opts *opts) > +{ > + int run_commit_flags = (flags & TODO_EDIT_MERGE_MSG) ? > + EDIT_MSG | VERIFY_MSG : 0; > +

[PATCH v6 05/15] sequencer: introduce the `merge` command

2018-04-10 Thread Johannes Schindelin
This patch is part of the effort to reimplement `--preserve-merges` with a substantially improved design, a design that has been developed in the Git for Windows project to maintain the dozens of Windows-specific patch series on top of upstream Git. The previous patch implemented the `label` and