Re: [PATCH v6 07/35] connect: convert get_remote_heads to use struct packet_reader

2018-03-27 Thread Duy Nguyen
On Tue, Mar 27, 2018 at 6:25 PM, Duy Nguyen wrote: > On Tue, Mar 27, 2018 at 6:11 PM, Jeff King wrote: >> On Tue, Mar 27, 2018 at 05:27:14PM +0200, Duy Nguyen wrote: >> >>> On Thu, Mar 15, 2018 at 10:31:14AM -0700, Brandon Williams wrote: >>> > In order to allow

Re: [PATCH v6 07/35] connect: convert get_remote_heads to use struct packet_reader

2018-03-27 Thread Brandon Williams
On 03/27, Duy Nguyen wrote: > On Tue, Mar 27, 2018 at 6:25 PM, Duy Nguyen wrote: > > On Tue, Mar 27, 2018 at 6:11 PM, Jeff King wrote: > >> On Tue, Mar 27, 2018 at 05:27:14PM +0200, Duy Nguyen wrote: > >> > >>> On Thu, Mar 15, 2018 at 10:31:14AM -0700, Brandon

Re: [PATCH v6 07/35] connect: convert get_remote_heads to use struct packet_reader

2018-03-27 Thread Duy Nguyen
On Tue, Mar 27, 2018 at 6:11 PM, Jeff King wrote: > On Tue, Mar 27, 2018 at 05:27:14PM +0200, Duy Nguyen wrote: > >> On Thu, Mar 15, 2018 at 10:31:14AM -0700, Brandon Williams wrote: >> > In order to allow for better control flow when protocol_v2 is introduced >> > +static enum

Re: [PATCH v6 07/35] connect: convert get_remote_heads to use struct packet_reader

2018-03-27 Thread Jeff King
On Tue, Mar 27, 2018 at 05:27:14PM +0200, Duy Nguyen wrote: > On Thu, Mar 15, 2018 at 10:31:14AM -0700, Brandon Williams wrote: > > In order to allow for better control flow when protocol_v2 is introduced > > +static enum protocol_version discover_version(struct packet_reader *reader) > > +{ > >

Re: [PATCH v6 07/35] connect: convert get_remote_heads to use struct packet_reader

2018-03-27 Thread Duy Nguyen
On Thu, Mar 15, 2018 at 10:31:14AM -0700, Brandon Williams wrote: > In order to allow for better control flow when protocol_v2 is introduced > +static enum protocol_version discover_version(struct packet_reader *reader) > +{ > + enum protocol_version version = protocol_unknown_version; > + > +

[PATCH v6 07/35] connect: convert get_remote_heads to use struct packet_reader

2018-03-15 Thread Brandon Williams
In order to allow for better control flow when protocol_v2 is introduced convert 'get_remote_heads()' to use 'struct packet_reader' to read packet lines. This enables a client to be able to peek the first line of a server's response (without consuming it) in order to determine the protocol