Re: [PATCH v6 09/40] Add initial external odb support

2017-10-03 Thread Jonathan Tan
On Tue, Oct 3, 2017 at 2:45 AM, Christian Couder wrote: > Yeah, some people need the faster solution, but my opinion is that > many other people would prefer the single shot protocol. > If all you want to do is a simple resumable clone using bundles for > example, then

Re: [PATCH v6 09/40] Add initial external odb support

2017-10-03 Thread Christian Couder
On Fri, Sep 29, 2017 at 10:36 PM, Jonathan Tan wrote: > On Wed, 27 Sep 2017 18:46:30 +0200 > Christian Couder wrote: >> I don't think single-shot processes would be a huge burden, because >> the code is simpler, and because for example for

Re: [PATCH v6 09/40] Add initial external odb support

2017-10-02 Thread Ben Peart
On 9/29/2017 4:36 PM, Jonathan Tan wrote: On Wed, 27 Sep 2017 18:46:30 +0200 Christian Couder wrote: I am ok to split the patch series, but I am not sure that 01/40 to 09/40 is the right range for the first patch series. I would say that 01/40 to 07/40 is better

Re: [PATCH v6 09/40] Add initial external odb support

2017-09-29 Thread Jonathan Tan
On Wed, 27 Sep 2017 18:46:30 +0200 Christian Couder wrote: > I am ok to split the patch series, but I am not sure that 01/40 to > 09/40 is the right range for the first patch series. > I would say that 01/40 to 07/40 is better as it can be seen as a > separate

Re: [PATCH v6 09/40] Add initial external odb support

2017-09-27 Thread Christian Couder
On Tue, Sep 19, 2017 at 7:45 PM, Jonathan Tan wrote: > I wonder if it's better to get a change like this (PATCH v6 09/40 and > any of the previous patches that this depends on) in and then build on > it rather than to review the whole patch set at a time. This would >

Re: [PATCH v6 09/40] Add initial external odb support

2017-09-19 Thread Jonathan Tan
I wonder if it's better to get a change like this (PATCH v6 09/40 and any of the previous patches that this depends on) in and then build on it rather than to review the whole patch set at a time. This would reduce ripple effects (of needing to change later patches in a patch set multiple times

[PATCH v6 09/40] Add initial external odb support

2017-09-16 Thread Christian Couder
The external-odb.{c,h} files contains the functions that are called by the rest of Git from "sha1_file.c". The odb-helper.{c,h} files contains the functions to actually implement communication with the external scripts or processes that will manage external git objects. For now only script mode