Re: [PATCH v6 1/2] http-backend: respect CONTENT_LENGTH as specified by rfc3875

2017-12-04 Thread Jeff King
On Mon, Dec 04, 2017 at 07:18:55AM +, Florian Manschwetus wrote: > I could provide a bash script I used in between to make this working > with IIS, without fixing http-backend binary, maybe this helps to > understand how this cases might be handled. I think it would be pretty easy to handle

AW: [PATCH v6 1/2] http-backend: respect CONTENT_LENGTH as specified by rfc3875

2017-12-03 Thread Florian Manschwetus
t; Von: Junio C Hamano [mailto:gits...@pobox.com] > Gesendet: Sonntag, 3. Dezember 2017 07:07 > An: Jeff King > Cc: Max Kirillov; Eric Sunshine; Florian Manschwetus; Chris Packham; > Konstantin Khomoutov; git@vger.kernel.org > Betreff: Re: [PATCH v6 1/2] http-backend: respect CONTENT_

Re: [PATCH v6 1/2] http-backend: respect CONTENT_LENGTH as specified by rfc3875

2017-12-02 Thread Junio C Hamano
Jeff King writes: > ... Eventually our fill() will block trying to get data that is > not there. On an Apache server, the webserver would know there is > nothing left to send us and close() the pipe, and we'd get EOF. > But on IIS, I think the pipe remains open and we'd just block

Re: [PATCH v6 1/2] http-backend: respect CONTENT_LENGTH as specified by rfc3875

2017-12-02 Thread Jeff King
On Sat, Dec 02, 2017 at 05:02:37PM -0800, Junio C Hamano wrote: > Jeff King writes: > > > 3. For large inputs (like incoming packfiles), we connect the > > descriptor directly to index-pack or unpack-objects, and they try > > to read to EOF. > > > > For a

Re: [PATCH v6 1/2] http-backend: respect CONTENT_LENGTH as specified by rfc3875

2017-12-02 Thread Junio C Hamano
Jeff King writes: > 3. For large inputs (like incoming packfiles), we connect the > descriptor directly to index-pack or unpack-objects, and they try > to read to EOF. > > For a well-formed pack, I _think_ this would work OK. We'd see the > end of the pack

Re: [PATCH v6 1/2] http-backend: respect CONTENT_LENGTH as specified by rfc3875

2017-11-28 Thread Jeff King
On Sun, Nov 26, 2017 at 09:38:12PM +0200, Max Kirillov wrote: > From: Florian Manschwetus > Date: Wed, 30 Mar 2016 10:54:21 +0200 > > http-backend reads whole input until EOF. However, the RFC 3875 specifies > that a script must read only as many bytes as

Re: [PATCH v6 1/2] http-backend: respect CONTENT_LENGTH as specified by rfc3875

2017-11-26 Thread Eric Sunshine
On Sun, Nov 26, 2017 at 2:38 PM, Max Kirillov wrote: > [...] > Make http-backend read only CONTENT_LENGTH bytes, if it's defined, rather than > the whole input until EOF. If the variable is not defined, keep older behavior > of reading until EOF because it is used to support

[PATCH v6 1/2] http-backend: respect CONTENT_LENGTH as specified by rfc3875

2017-11-26 Thread Max Kirillov
From: Florian Manschwetus From: Florian Manschwetus Date: Wed, 30 Mar 2016 10:54:21 +0200 http-backend reads whole input until EOF. However, the RFC 3875 specifies that a script must read only as many bytes as specified by