Re: [PATCH v6 1/6] t0021: keep filter log files on comparison

Lars Schneider writes: >> It would become a problem _if_ we want future users of this helper >> to reuse the same expect (or actual) multiple times and start from >> an unmodified one. There may be some other reason why you do not >> want the comparison to smudge these

Re: [PATCH v6 1/6] t0021: keep filter log files on comparison

> On 26 Jun 2017, at 00:12, Junio C Hamano wrote: > > Lars Schneider writes: > >> The filter log files are modified on comparison. Write the modified log files >> to temp files for comparison to fix this. > > The phrase "to fix this" implies that

Re: [PATCH v6 1/6] t0021: keep filter log files on comparison

Lars Schneider writes: > The filter log files are modified on comparison. Write the modified log files > to temp files for comparison to fix this. The phrase "to fix this" implies that it is _wrong_ to modify after comparing it, but it is unclear _why_ you think is

[PATCH v6 1/6] t0021: keep filter log files on comparison

The filter log files are modified on comparison. Write the modified log files to temp files for comparison to fix this. This is useful for the subsequent patch 'convert: add "status=delayed" to filter process protocol'. Signed-off-by: Lars Schneider ---