Re: [PATCH v6 2/2] builtin/config.c: support `--type=` as preferred alias for `--type`

2018-04-07 Thread Eric Sunshine
On Fri, Apr 6, 2018 at 8:39 PM, Taylor Blau wrote: > On Fri, Apr 06, 2018 at 03:04:53AM -0400, Eric Sunshine wrote: >> Sorry for being such a stickler, but this is still too mushy. The >> first two sentences are saying effectively the same thing. One or the >> other should be

Re: [PATCH v6 2/2] builtin/config.c: support `--type=` as preferred alias for `--type`

2018-04-06 Thread Taylor Blau
On Fri, Apr 06, 2018 at 03:04:53AM -0400, Eric Sunshine wrote: > On Fri, Apr 6, 2018 at 2:39 AM, Taylor Blau wrote: > > [...] > > In this patch, we support `--type=` in > > addition to `--int`, `--bool`, and etc. This allows the aforementioned > >

Re: [PATCH v6 2/2] builtin/config.c: support `--type=` as preferred alias for `--type`

2018-04-06 Thread Eric Sunshine
On Fri, Apr 6, 2018 at 2:39 AM, Taylor Blau wrote: > [...] > In this patch, we support `--type=` in > addition to `--int`, `--bool`, and etc. This allows the aforementioned > upcoming patch to support querying a color value with a default via >

[PATCH v6 2/2] builtin/config.c: support `--type=` as preferred alias for `--type`

2018-04-06 Thread Taylor Blau
`git config` has long allowed the ability for callers to provide a 'type specifier', which instructs `git config` to (1) ensure that incoming values are satisfiable under that type, and (2) that outgoing values are canonicalized under that type. In another series, we propose to extend this