Re: [PATCH v6 2/3] Makefile: add Perl runtime prefix support

2018-03-19 Thread Daniel Jacques
On Mon, Mar 19, 2018 at 5:32 PM Martin Ågren wrote: > This commit message mentions RUNTIME_PREFIX_PERL twice, but there is no > use of RUNTIME_PREFIX_PERL in the actual diffs (patches 1-3/3). Should > it be s/_PERL//? Your cover letter hints as much under "Changes in v6 >

Re: [PATCH v6 2/3] Makefile: add Perl runtime prefix support

2018-03-19 Thread Martin Ågren
On 19 March 2018 at 03:50, Dan Jacques wrote: > Add a new Makefile flag, RUNTIME_PREFIX_PERL, which, when enabled, > configures Perl scripts to locate the Git installation's Perl support > libraries by resolving against the script's path, rather than > hard-coding that path at

Re: [PATCH v6 2/3] Makefile: add Perl runtime prefix support

2018-03-19 Thread Junio C Hamano
Daniel Jacques writes: >> > The merge conflict becomes a tad easier to deal with, also makes sense >> > to have gitexecdir after infodir since that's the order we're listing >> > these in just a few lines earlier, and this is otherwise (mostly) >> > consistent. > > Actually as a

Re: [PATCH v6 2/3] Makefile: add Perl runtime prefix support

2018-03-19 Thread Daniel Jacques
On Mon, Mar 19, 2018 at 3:21 PM Ævar Arnfjörð Bjarmason wrote: > I think it would be more idiomatic and more paranoid (we'll catch bugs) > to do: > my $exec_path; > if (exists $ENV{GIT_EXEC_PATH}) { > $exec_path = $ENV{GIT_EXEC_PATH}; > } else { >

Re: [PATCH v6 2/3] Makefile: add Perl runtime prefix support

2018-03-19 Thread Daniel Jacques
> > The merge conflict becomes a tad easier to deal with, also makes sense > > to have gitexecdir after infodir since that's the order we're listing > > these in just a few lines earlier, and this is otherwise (mostly) > > consistent. Actually as a quick follow-up question: for these patch sets,

Re: [PATCH v6 2/3] Makefile: add Perl runtime prefix support

2018-03-19 Thread Daniel Jacques
On Mon, Mar 19, 2018 at 3:12 PM Ævar Arnfjörð Bjarmason wrote: > The merge conflict becomes a tad easier to deal with, also makes sense > to have gitexecdir after infodir since that's the order we're listing > these in just a few lines earlier, and this is otherwise (mostly) >

Re: [PATCH v6 2/3] Makefile: add Perl runtime prefix support

2018-03-19 Thread Ævar Arnfjörð Bjarmason
On Mon, Mar 19 2018, Dan Jacques jotted: > +gitexecdir_relative = $(patsubst $(prefix)/%,%,$(gitexecdir)) > mandir_relative = $(patsubst $(prefix)/%,%,$(mandir)) > infodir_relative = $(patsubst $(prefix)/%,%,$(infodir)) > +localedir_relative = $(patsubst $(prefix)/%,%,$(localedir)) >

Re: [PATCH v6 2/3] Makefile: add Perl runtime prefix support

2018-03-19 Thread Daniel Jacques
On Mon, Mar 19, 2018 at 1:14 PM Junio C Hamano wrote: > > +# RUNTIME_PREFIX's resolution logic requires resource paths to be expressed > > +# relative to each other and share an installation path. > > +# > > +# This is a dependnecy in: > dependency? Oops, this is the second

Re: [PATCH v6 2/3] Makefile: add Perl runtime prefix support

2018-03-19 Thread Junio C Hamano
Dan Jacques writes: > +# RUNTIME_PREFIX's resolution logic requires resource paths to be expressed > +# relative to each other and share an installation path. > +# > +# This is a dependnecy in: dependency? > +# - Git's binary RUNTIME_PREFIX logic in (see "exec_cmd.c"). > +# -

[PATCH v6 2/3] Makefile: add Perl runtime prefix support

2018-03-18 Thread Dan Jacques
Add a new Makefile flag, RUNTIME_PREFIX_PERL, which, when enabled, configures Perl scripts to locate the Git installation's Perl support libraries by resolving against the script's path, rather than hard-coding that path at build-time. RUNTIME_PREFIX_PERL requires that system paths are expressed