Re: [PATCH v6 2/6] reset: introduce show-new-head-line option

2018-04-02 Thread Thomas Gummerer
On 04/02, Junio C Hamano wrote: > This is completely offtopic tangent, but I wonder how hidden-bool or > hidden options[] element in general interacts with the recent > addition of helping command line completion. Are we already doing > the right thing? I had a quick look at this, and it looks

Re: [PATCH v6 2/6] reset: introduce show-new-head-line option

2018-04-02 Thread Thomas Gummerer
On 04/02, Junio C Hamano wrote: > Thomas Gummerer writes: > > > +test_expect_success 'reset --no-show-new-head-line suppresses "HEAD is now > > at" output' ' > > + git reset --hard --no-show-new-head-line HEAD >actual && > > + ! grep "HEAD is now at" > +' > > As

Re: [PATCH v6 2/6] reset: introduce show-new-head-line option

2018-04-02 Thread Thomas Gummerer
On 04/02, Junio C Hamano wrote: > Thomas Gummerer writes: > > > Introduce a new --show-new-head-line command line option, that > > determines whether the "HEAD is now at ..." message is printed or not. > > It is enabled by default to preserve the current behaviour. > > > >

Re: [PATCH v6 2/6] reset: introduce show-new-head-line option

2018-04-02 Thread Junio C Hamano
Thomas Gummerer writes: > +test_expect_success 'reset --no-show-new-head-line suppresses "HEAD is now > at" output' ' > + git reset --hard --no-show-new-head-line HEAD >actual && > + ! grep "HEAD is now at" +' As builtin/reset.c::print_new_head_line() does this:

Re: [PATCH v6 2/6] reset: introduce show-new-head-line option

2018-04-02 Thread Junio C Hamano
Thomas Gummerer writes: > Introduce a new --show-new-head-line command line option, that > determines whether the "HEAD is now at ..." message is printed or not. > It is enabled by default to preserve the current behaviour. > > It will be used in a subsequent commit to

[PATCH v6 2/6] reset: introduce show-new-head-line option

2018-03-31 Thread Thomas Gummerer
Introduce a new --show-new-head-line command line option, that determines whether the "HEAD is now at ..." message is printed or not. It is enabled by default to preserve the current behaviour. It will be used in a subsequent commit to disable printing the "HEAD is now at ..." line in 'git