Re: [PATCH v6 3/3] exec_cmd: RUNTIME_PREFIX on some POSIX systems

2018-03-19 Thread Daniel Jacques
On Mon, Mar 19, 2018 at 3:27 PM Ævar Arnfjörð Bjarmason wrote: > I wonder if it wouldn't be a lot more understandable if these were noted > together, i.e. let's first document RUNTIME_PREFIX, then for all the > other ones say below that: Sounds good to me, done. > Whitespace

Re: [PATCH v6 3/3] exec_cmd: RUNTIME_PREFIX on some POSIX systems

2018-03-19 Thread Ævar Arnfjörð Bjarmason
On Mon, Mar 19 2018, Dan Jacques jotted: > # > # Define HAVE_BSD_SYSCTL if your platform has a BSD-compatible sysctl > function. > # > +# Define HAVE_BSD_KERN_PROC_SYSCTL if your platform supports the KERN_PROC > BSD > +# sysctl function. > +# > +# Define PROCFS_EXECUTABLE_PATH if your

Re: [PATCH v6 3/3] exec_cmd: RUNTIME_PREFIX on some POSIX systems

2018-03-19 Thread Daniel Jacques
On Mon, Mar 19, 2018 at 1:24 PM Junio C Hamano wrote: > Look for these misspelled words: Oh boy ... thanks, and done. > OK. An essentially no-op change but with the name better suited in > the extended context---we used to only care about argv0 but that was > an

Re: [PATCH v6 3/3] exec_cmd: RUNTIME_PREFIX on some POSIX systems

2018-03-19 Thread Junio C Hamano
Dan Jacques writes: > Enable Git to resolve its own binary location using a variety of > OS-specific and generic methods, including: > > - procfs via "/proc/self/exe" (Linux) > - _NSGetExecutablePath (Darwin) > - KERN_PROC_PATHNAME sysctl on BSDs. > - argv0, if absolute (all,

[PATCH v6 3/3] exec_cmd: RUNTIME_PREFIX on some POSIX systems

2018-03-18 Thread Dan Jacques
Enable Git to resolve its own binary location using a variety of OS-specific and generic methods, including: - procfs via "/proc/self/exe" (Linux) - _NSGetExecutablePath (Darwin) - KERN_PROC_PATHNAME sysctl on BSDs. - argv0, if absolute (all, including Windows). This is used to enable