Re: [PATCH v6 4/4] stash: convert pop to builtin

2018-06-26 Thread Johannes Schindelin
Hi Paul, I think I had revewied these 4 patches before, and I'd wager a bet that you addressed all of my suggestions, if any. I had a look over patches 2-4, and want to take a little bit more time tomorrow to pour over patch 1 (which is a little larger, as it lays a lot of ground work), to make s

[PATCH v6 4/4] stash: convert pop to builtin

2018-06-25 Thread Paul-Sebastian Ungureanu
From: Joel Teichroeb Add stash pop to the helper and delete the pop_stash, drop_stash, assert_stash_ref functions from the shell script now that they are no longer needed. Signed-off-by: Joel Teichroeb Signed-off-by: Paul-Sebastian Ungureanu --- builtin/stash--helper.c | 36 ++