Re: [PATCH v6 4/7] config: add new index.threads config setting

2018-10-01 Thread SZEDER Gábor
On Mon, Oct 01, 2018 at 09:17:53AM -0400, Ben Peart wrote: > > > On 9/28/2018 6:15 PM, Junio C Hamano wrote: > >Ramsay Jones writes: > > > >>>     if (!nr) { > >>>     ieot_blocks = istate->cache_nr / THREAD_COST; > >>>-   if (ieot_blocks < 1)

Re: [PATCH v6 4/7] config: add new index.threads config setting

2018-10-01 Thread Ben Peart
On 9/28/2018 6:15 PM, Junio C Hamano wrote: Ramsay Jones writes:     if (!nr) {     ieot_blocks = istate->cache_nr / THREAD_COST; -   if (ieot_blocks < 1) -   ieot_blocks = 1;     cpus =

Re: [PATCH v6 4/7] config: add new index.threads config setting

2018-09-28 Thread Junio C Hamano
Ramsay Jones writes: >>     if (!nr) { >>     ieot_blocks = istate->cache_nr / THREAD_COST; >> -   if (ieot_blocks < 1) >> -   ieot_blocks = 1; >>     cpus = online_cpus(); >>  

Re: [PATCH v6 4/7] config: add new index.threads config setting

2018-09-28 Thread Ramsay Jones
On 28/09/18 20:41, Ben Peart wrote: > > > On 9/28/2018 1:07 PM, Junio C Hamano wrote: >> Ben Peart writes: >> Why does multithreading have to be disabled in this test? >>> >>> If multi-threading is enabled, it will write out the IEOT extension >>> which changes the SHA and causes the

Re: [PATCH v6 4/7] config: add new index.threads config setting

2018-09-28 Thread Ben Peart
On 9/28/2018 1:07 PM, Junio C Hamano wrote: Ben Peart writes: Why does multithreading have to be disabled in this test? If multi-threading is enabled, it will write out the IEOT extension which changes the SHA and causes the test to fail. I think it is a design mistake to let the

Re: [PATCH v6 4/7] config: add new index.threads config setting

2018-09-28 Thread Junio C Hamano
Ben Peart writes: >> Why does multithreading have to be disabled in this test? > > If multi-threading is enabled, it will write out the IEOT extension > which changes the SHA and causes the test to fail. I think it is a design mistake to let the writing processes's capability decide what is

Re: [PATCH v6 4/7] config: add new index.threads config setting

2018-09-28 Thread Ben Peart
On 9/27/2018 8:26 PM, SZEDER Gábor wrote: On Wed, Sep 26, 2018 at 03:54:39PM -0400, Ben Peart wrote: Add support for a new index.threads config setting which will be used to control the threading code in do_read_index(). A value of 0 will tell the index code to automatically determine the

Re: [PATCH v6 4/7] config: add new index.threads config setting

2018-09-27 Thread SZEDER Gábor
On Wed, Sep 26, 2018 at 03:54:39PM -0400, Ben Peart wrote: > Add support for a new index.threads config setting which will be used to > control the threading code in do_read_index(). A value of 0 will tell the > index code to automatically determine the correct number of threads to use. > A value

[PATCH v6 4/7] config: add new index.threads config setting

2018-09-26 Thread Ben Peart
Add support for a new index.threads config setting which will be used to control the threading code in do_read_index(). A value of 0 will tell the index code to automatically determine the correct number of threads to use. A value of 1 will make the code single threaded. A value greater than 1