Re: [PATCH v7] git-p4: improve path encoding verbose output

On 15/09/15 08:31, Luke Diamand wrote: On 14/09/15 18:10, larsxschnei...@gmail.com wrote: It would be better to query this once at startup. Otherwise we're potentially forking "git config" twice per file which on a large repo could become significant. Make it an instance variable perhaps?

Re: [PATCH v7] git-p4: improve path encoding verbose output

On 14/09/15 18:10, larsxschnei...@gmail.com wrote: From: Lars Schneider If a path with non-ASCII characters is detected then print always the s/print always/print/ encoding and the encoded string in verbose mode. Signed-off-by: Lars Schneider

Re: [PATCH v7] git-p4: improve path encoding verbose output

On 15 Sep 2015, at 09:31, Luke Diamand wrote: > On 14/09/15 18:10, larsxschnei...@gmail.com wrote: >> From: Lars Schneider >> >> If a path with non-ASCII characters is detected then print always the > > s/print always/print/ I will fix it. > >

Re: [PATCH v7] git-p4: improve path encoding verbose output

On 14 Sep 2015, at 20:40, Junio C Hamano wrote: > larsxschnei...@gmail.com writes: > >> From: Lars Schneider >> >> If a path with non-ASCII characters is detected then print always the >> encoding and the encoded string in verbose mode. > >

[PATCH v7] git-p4: improve path encoding verbose output

From: Lars Schneider If a path with non-ASCII characters is detected then print always the encoding and the encoded string in verbose mode. Signed-off-by: Lars Schneider --- git-p4.py | 19 +-- 1 file changed, 9

Re: [PATCH v7] git-p4: improve path encoding verbose output

larsxschnei...@gmail.com writes: > From: Lars Schneider > > If a path with non-ASCII characters is detected then print always the > encoding and the encoded string in verbose mode. Earlier if the user tells us that s/he knows what she is doing by setting the