Re: [PATCH v7 0/3] Conditional config include

2017-03-03 Thread Junio C Hamano
Jeff King writes: > Heh. I had no idea we had FREAD_READS_DIRECTORIES. I think Duy and I > reinvented it in another thread. ;) You two were not alone. I was planning to reinvent it before I went to bed last night and then found it already was there this morning ;-) > I agree

Re: [PATCH v7 0/3] Conditional config include

2017-03-03 Thread Jeff King
On Fri, Mar 03, 2017 at 10:24:05AM -0800, Junio C Hamano wrote: > Jeff King writes: > > > For those following on the mailing list, there is some discussion at: > > > > https://github.com/git/git/commit/484f78e46d00c6d35f20058671a8c76bb924fb33 > > > > I think that is mostly

Re: [PATCH v7 0/3] Conditional config include

2017-03-03 Thread Junio C Hamano
Duy Nguyen writes: > On Fri, Mar 03, 2017 at 01:33:29AM -0500, Jeff King wrote: >> For those following on the mailing list, there is some discussion at: >> >> https://github.com/git/git/commit/484f78e46d00c6d35f20058671a8c76bb924fb33 >> >> I think that is mostly focused

Re: [PATCH v7 0/3] Conditional config include

2017-03-03 Thread Junio C Hamano
Duy Nguyen writes: > The patch to fix it is this > > diff --git a/t/t1305-config-include.sh b/t/t1305-config-include.sh > index f0cd2056ba..e833939320 100755 > --- a/t/t1305-config-include.sh > +++ b/t/t1305-config-include.sh > @@ -102,7 +102,7 @@ test_expect_success 'config

Re: [PATCH v7 0/3] Conditional config include

2017-03-03 Thread Junio C Hamano
Jeff King writes: > For those following on the mailing list, there is some discussion at: > > https://github.com/git/git/commit/484f78e46d00c6d35f20058671a8c76bb924fb33 > > I think that is mostly focused around another failing in the > error-handling of the config code, and that

Re: [PATCH v7 0/3] Conditional config include

2017-03-03 Thread Duy Nguyen
On Fri, Mar 03, 2017 at 01:33:29AM -0500, Jeff King wrote: > For those following on the mailing list, there is some discussion at: > > https://github.com/git/git/commit/484f78e46d00c6d35f20058671a8c76bb924fb33 > > I think that is mostly focused around another failing in the > error-handling of

Re: [PATCH v7 0/3] Conditional config include

2017-03-02 Thread Jeff King
On Wed, Mar 01, 2017 at 06:26:28PM +0700, Nguyễn Thái Ngọc Duy wrote: > I don't have a good answer for Jeff's PS about includeIf ugliness. I > agree that includeif is ugly but includeIf looks a bit better. I don't > see a better option (if only "include" does not start or end with a > vowel...).

Re: [PATCH v7 0/3] Conditional config include

2017-03-01 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Nguyễn Thái Ngọc Duy (3): > config.txt: clarify multiple key values in include.path > config.txt: reflow the second include.path paragraph > config: add conditional include Thanks. The primary change looked good (it looked good already

[PATCH v7 0/3] Conditional config include

2017-03-01 Thread Nguyễn Thái Ngọc Duy
v7 changes: - typo fix here and there - delete a dead TODO comment - delete the error on unrecognized condition (we probably want a better, general mechanism for troubleshooting config keys anyway) - some fix up on include.path document because the "one or many" confusion started from