Re: [PATCH v7 00/10] interactive git clean

2013-05-12 Thread Matthieu Moy
Jiang Xin writes: > My initial intention for flags toggle is for git newbies, who are not clear > about how to use -x/-d/-X/-ff options. I feel it may have values for these > people. It may have value for some of them, but throwing too many options in a menu is usually counter-productive for a n

Re: [PATCH v7 00/10] interactive git clean

2013-05-12 Thread Jiang Xin
2013/5/13 Matthieu Moy : > Junio C Hamano writes: > >> Cleaning all unneeded files inside a single interactive session >> should *never* be the goal---that will lead to an over-engineered >> design (e.g. switching "clean -x" flags in the middle? why?). I >> think Jiang's latest series is already

Re: [PATCH v7 00/10] interactive git clean

2013-05-12 Thread Matthieu Moy
Junio C Hamano writes: > Cleaning all unneeded files inside a single interactive session > should *never* be the goal---that will lead to an over-engineered > design (e.g. switching "clean -x" flags in the middle? why?). I > think Jiang's latest series is already way over-engineered, I didn't r

Re: [PATCH v7 00/10] interactive git clean

2013-05-08 Thread Junio C Hamano
Eric Sunshine writes: > On Wed, May 8, 2013 at 7:38 AM, Jiang Xin wrote: >> When the command enters the interactive mode, it shows the >> files and directories to be cleaned, and goes into its >> interactive command loop. > > Your current implementation only allows excluding items from the list

Re: [PATCH v7 00/10] interactive git clean

2013-05-08 Thread Eric Sunshine
On Wed, May 8, 2013 at 11:15 AM, Eric Sunshine wrote: > On Wed, May 8, 2013 at 7:38 AM, Jiang Xin wrote: >> *** Commands *** >> 1: clean 2: edit by patterns3: edit by numbers >> 4: rm -i >> 5: flags: none 6: quit7: help >> What no

Re: [PATCH v7 00/10] interactive git clean

2013-05-08 Thread Eric Sunshine
On Wed, May 8, 2013 at 7:38 AM, Jiang Xin wrote: > When the command enters the interactive mode, it shows the > files and directories to be cleaned, and goes into its > interactive command loop. Your current implementation only allows excluding items from the list of files to delete. If you accid

[PATCH v7 00/10] interactive git clean

2013-05-08 Thread Jiang Xin
Significant updates since patch v6 series: * Refactor on patch 4/10: split `list_and_choose` into 3 functions, to make it easy to read. * Mark no public functions as static for patch 1-10. * If set 'pager.clean' to true (i.e. isatty(1) is false), die instead of do cleaning. * New acti