Re: [PATCH v7 00/28] Remove submodule from files-backend.c

2017-04-11 Thread Junio C Hamano
Michael Haggerty writes: > On 03/26/2017 04:42 AM, Nguyễn Thái Ngọc Duy wrote: >> v7 is mostly about style changes except the one bug in >> test-ref-store.c, missing setup_git_directory(). >> >> There's one new patch, 03/28, which maps to the "if (!refs)" deletion >> in

Re: [PATCH v7 00/28] Remove submodule from files-backend.c

2017-03-31 Thread Michael Haggerty
On 03/26/2017 04:42 AM, Nguyễn Thái Ngọc Duy wrote: > v7 is mostly about style changes except the one bug in > test-ref-store.c, missing setup_git_directory(). > > There's one new patch, 03/28, which maps to the "if (!refs)" deletion > in the interdiff. > > The one comment from v6 I haven't

[PATCH v7 00/28] Remove submodule from files-backend.c

2017-03-25 Thread Nguyễn Thái Ngọc Duy
v7 is mostly about style changes except the one bug in test-ref-store.c, missing setup_git_directory(). There's one new patch, 03/28, which maps to the "if (!refs)" deletion in the interdiff. The one comment from v6 I haven't addressed in v7 is whether to delete REF_STORE_READ. But if it is