Re: [PATCH v7 03/11] trailer: read and process config information

2014-03-07 Thread Junio C Hamano
David Kastrup writes: > Junio C Hamano writes: > >> Christian Couder writes: >> >>> The config information is stored in the list >>> whose first item is pointed to by: >>> >>> static struct trailer_item *first_conf_item; >> >> If feels somewhat strange ... > > Can't say I agree here. Basically

Re: [PATCH v7 03/11] trailer: read and process config information

2014-03-07 Thread David Kastrup
Junio C Hamano writes: > Christian Couder writes: > >> This patch implements reading the configuration >> to get trailer information, and then processing >> it and storing it in a doubly linked list. > > "Read and process the ...", perhaps? > >> The config information is stored in the list >> wh

Re: [PATCH v7 03/11] trailer: read and process config information

2014-03-07 Thread Junio C Hamano
Christian Couder writes: > This patch implements reading the configuration > to get trailer information, and then processing > it and storing it in a doubly linked list. "Read and process the ...", perhaps? > The config information is stored in the list > whose first item is pointed to by: > >

[PATCH v7 03/11] trailer: read and process config information

2014-03-06 Thread Christian Couder
This patch implements reading the configuration to get trailer information, and then processing it and storing it in a doubly linked list. The config information is stored in the list whose first item is pointed to by: static struct trailer_item *first_conf_item; Signed-off-by: Christian Couder