Re: [PATCH v7 04/17] ref-filter: modify "%(objectname:short)" to take length

2016-11-12 Thread Karthik Nayak
Hello, On Fri, Nov 11, 2016 at 10:59 AM, Jacob Keller wrote: > On Thu, Nov 10, 2016 at 9:36 AM, Karthik Nayak wrote: >> On Wed, Nov 9, 2016 at 4:57 AM, Jacob Keller wrote: >> >> That does make sense, It would also not error

Re: [PATCH v7 04/17] ref-filter: modify "%(objectname:short)" to take length

2016-11-10 Thread Jacob Keller
On Thu, Nov 10, 2016 at 9:36 AM, Karthik Nayak wrote: > On Wed, Nov 9, 2016 at 4:57 AM, Jacob Keller wrote: >> On Tue, Nov 8, 2016 at 12:11 PM, Karthik Nayak wrote: >>> From: Karthik Nayak >>> >>> Add

Re: [PATCH v7 04/17] ref-filter: modify "%(objectname:short)" to take length

2016-11-10 Thread Junio C Hamano
Karthik Nayak writes: > else if (!strcmp(arg, "short")) > - atom->u.objectname = O_SHORT; > - else > + atom->u.objectname.option = O_SHORT; > + else if (skip_prefix(arg, "short=", )) { > + atom->u.objectname.option =

Re: [PATCH v7 04/17] ref-filter: modify "%(objectname:short)" to take length

2016-11-10 Thread Karthik Nayak
On Wed, Nov 9, 2016 at 4:57 AM, Jacob Keller wrote: > On Tue, Nov 8, 2016 at 12:11 PM, Karthik Nayak wrote: >> From: Karthik Nayak >> >> Add support for %(objectname:short=) which would print the >> abbreviated unique

Re: [PATCH v7 04/17] ref-filter: modify "%(objectname:short)" to take length

2016-11-08 Thread Jacob Keller
On Tue, Nov 8, 2016 at 12:11 PM, Karthik Nayak wrote: > From: Karthik Nayak > > Add support for %(objectname:short=) which would print the > abbreviated unique objectname of given length. When no length is > specified, the length is 'DEFAULT_ABBREV'.

[PATCH v7 04/17] ref-filter: modify "%(objectname:short)" to take length

2016-11-08 Thread Karthik Nayak
From: Karthik Nayak Add support for %(objectname:short=) which would print the abbreviated unique objectname of given length. When no length is specified, the length is 'DEFAULT_ABBREV'. The minimum length is 'MINIMUM_ABBREV'. The length may be exceeded to ensure that the