Re: [PATCH v7 08/14] commit-graph: implement git commit-graph read

2018-04-08 Thread Jakub Narebski
Derrick Stolee writes: [...] > EXAMPLES > > @@ -45,6 +51,12 @@ EXAMPLES > $ git commit-graph write > > > +* Read basic information from the commit-graph file. > ++ >

Re: [PATCH v7 08/14] commit-graph: implement git commit-graph read

2018-04-03 Thread Derrick Stolee
On 4/2/2018 5:33 PM, Junio C Hamano wrote: Derrick Stolee writes: From: Derrick Stolee ... +static int graph_read(int argc, const char **argv) +{ + struct commit_graph *graph = 0; The previous round said NULL above, not 0, and NULL is the

Re: [PATCH v7 08/14] commit-graph: implement git commit-graph read

2018-04-02 Thread Junio C Hamano
Derrick Stolee writes: > From: Derrick Stolee > ... > +static int graph_read(int argc, const char **argv) > +{ > + struct commit_graph *graph = 0; The previous round said NULL above, not 0, and NULL is the better way to spell it, I would think.

[PATCH v7 08/14] commit-graph: implement git commit-graph read

2018-04-02 Thread Derrick Stolee
From: Derrick Stolee Teach git-commit-graph to read commit graph files and summarize their contents. Use the read subcommand to verify the contents of a commit graph file in the tests. Signed-off-by: Derrick Stolee ---