Re: [PATCH v7 09/10] submodule: support reading .gitmodules when it's not in the working tree

2018-10-31 Thread Junio C Hamano
Antonio Ospite writes: > I see, this is also mentioned in t/README, I had overlooked that part. > Thank you for reporting. > >> Without this fix, your new test case will fail on Windows all the time, >> see e.g. >> https://git-for-windows.visualstudio.com/git/_build/results?buildId=22913=logs >>

Re: [PATCH v7 09/10] submodule: support reading .gitmodules when it's not in the working tree

2018-10-30 Thread Antonio Ospite
On Tue, 30 Oct 2018 10:57:09 +0100 (STD) Johannes Schindelin wrote: > Hi Antonio, > Hi Johannes, > On Thu, 25 Oct 2018, Antonio Ospite wrote: > > > diff --git a/t/t7418-submodule-sparse-gitmodules.sh > > b/t/t7418-submodule-sparse-gitmodules.sh > > new file mode 100755 [...] > > + echo

Re: [PATCH v7 09/10] submodule: support reading .gitmodules when it's not in the working tree

2018-10-30 Thread Johannes Schindelin
Hi Antonio, On Thu, 25 Oct 2018, Antonio Ospite wrote: > diff --git a/t/t7418-submodule-sparse-gitmodules.sh > b/t/t7418-submodule-sparse-gitmodules.sh > new file mode 100755 > index 00..21a86b89c6 > --- /dev/null > +++ b/t/t7418-submodule-sparse-gitmodules.sh > @@ -0,0 +1,122 @@ >

[PATCH v7 09/10] submodule: support reading .gitmodules when it's not in the working tree

2018-10-25 Thread Antonio Ospite
When the .gitmodules file is not available in the working tree, try using the content from the index and from the current branch. This covers the case when the file is part of the repository but for some reason it is not checked out, for example because of a sparse checkout. This makes it