Re: [PATCH v7 09/17] ref-filter: make "%(symref)" atom work with the ':short' modifier

2016-11-19 Thread Karthik Nayak
On Sat, Nov 19, 2016 at 3:04 AM, Jakub Narębski wrote: > W dniu 08.11.2016 o 21:12, Karthik Nayak pisze: >> >> Helped-by: Junio C Hamano >> Signed-off-by: Karthik Nayak >> --- > [...] > >> +test_expect_success 'Add symbolic ref for the

Re: [PATCH v7 09/17] ref-filter: make "%(symref)" atom work with the ':short' modifier

2016-11-18 Thread Jakub Narębski
W dniu 08.11.2016 o 21:12, Karthik Nayak pisze: [...] > Add tests for %(symref) and %(symref:short) while we're here. That's nice. > > Helped-by: Junio C Hamano > Signed-off-by: Karthik Nayak > --- [...] > +test_expect_success 'Add symbolic ref for

Re: [PATCH v7 09/17] ref-filter: make "%(symref)" atom work with the ':short' modifier

2016-11-08 Thread Jacob Keller
On Tue, Nov 8, 2016 at 12:12 PM, Karthik Nayak wrote: > From: Karthik Nayak > > The "%(symref)" atom doesn't work when used with the ':short' modifier > because we strictly match only 'symref' for setting the 'need_symref' > indicator. Fix this by

[PATCH v7 09/17] ref-filter: make "%(symref)" atom work with the ':short' modifier

2016-11-08 Thread Karthik Nayak
From: Karthik Nayak The "%(symref)" atom doesn't work when used with the ':short' modifier because we strictly match only 'symref' for setting the 'need_symref' indicator. Fix this by using comparing with valid_atom rather than used_atom. Add tests for %(symref) and