Re: [PATCH v7 19/31] merge-recursive: add get_directory_renames()

2018-02-05 Thread Stefan Beller
> /* > * For > *"a/b/c/d/e/foo.c" -> "a/b/some/thing/else/e/foo.c" > * the "e/foo.c" part is the same, we just want to know that > *"a/b/c/d" was renamed to "a/b/some/thing/else" > * so, for this example, this function returns "a/b/c/d" in > * *old_dir and

Re: [PATCH v7 19/31] merge-recursive: add get_directory_renames()

2018-02-03 Thread Eric Sunshine
On Sat, Feb 3, 2018 at 11:42 PM, Eric Sunshine wrote: > [2]: https://en.wikipedia.org/wiki/Diaeresis_(diacritic) Correction: [2]: https://en.wikipedia.org/wiki/Precomposed_character

Re: [PATCH v7 19/31] merge-recursive: add get_directory_renames()

2018-02-03 Thread Eric Sunshine
On Sat, Feb 3, 2018 at 9:04 PM, Elijah Newren wrote: > On Sat, Feb 3, 2018 at 2:32 PM, Elijah Newren wrote: >> On Fri, Feb 2, 2018 at 5:02 PM, Stefan Beller wrote: >>> On Tue, Jan 30, 2018 at 3:25 PM, Elijah Newren

Re: [PATCH v7 19/31] merge-recursive: add get_directory_renames()

2018-02-03 Thread Elijah Newren
On Sat, Feb 3, 2018 at 2:32 PM, Elijah Newren wrote: > On Fri, Feb 2, 2018 at 5:02 PM, Stefan Beller wrote: >> On Tue, Jan 30, 2018 at 3:25 PM, Elijah Newren wrote: >>> + while (*--end_of_new == *--end_of_old && >>> +

Re: [PATCH v7 19/31] merge-recursive: add get_directory_renames()

2018-02-03 Thread Elijah Newren
On Fri, Feb 2, 2018 at 5:02 PM, Stefan Beller wrote: > On Tue, Jan 30, 2018 at 3:25 PM, Elijah Newren wrote: >> + /* For > > comment style. Fixed it and looked through the file for any other violations and fixed the ones introduced in this series.

Re: [PATCH v7 19/31] merge-recursive: add get_directory_renames()

2018-02-02 Thread Stefan Beller
On Tue, Jan 30, 2018 at 3:25 PM, Elijah Newren wrote: > This populates a list of directory renames for us. The list of > directory renames is not yet used, but will be in subsequent commits. > > Signed-off-by: Elijah Newren > --- > merge-recursive.c | 155 >

[PATCH v7 19/31] merge-recursive: add get_directory_renames()

2018-01-30 Thread Elijah Newren
This populates a list of directory renames for us. The list of directory renames is not yet used, but will be in subsequent commits. Signed-off-by: Elijah Newren --- merge-recursive.c | 155 -- 1 file changed, 152