[PATCH 0/3] Avoid confusing messages from new index extensions (Re: [PATCH v8 0/7] speed up index load through parallelization)

2018-11-12 Thread Jonathan Nieder
Hi, Ben Peart wrote: > Ben Peart (6): > read-cache: clean up casting and byte decoding > eoie: add End of Index Entry (EOIE) extension > config: add new index.threads config setting > read-cache: load cache extensions on a worker thread > ieot: add Index Entry Offset Table (IEOT)

Re: [PATCH v8 0/7] speed up index load through parallelization

2018-10-15 Thread Ben Peart
fixup! IEOT error messages Enable localizing new error messages and improve the error message for invalid IEOT extension sizes. Signed-off-by: Ben Peart --- read-cache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/read-cache.c b/read-cache.c index

Re: [PATCH v8 0/7] speed up index load through parallelization

2018-10-14 Thread Duy Nguyen
On Wed, Oct 10, 2018 at 5:59 PM Ben Peart wrote: > @@ -3460,14 +3479,18 @@ static struct index_entry_offset_table > *read_ieot_extension(const char *mmap, si > > /* validate the version is IEOT_VERSION */ > ext_version = get_be32(index); > - if (ext_version != IEOT_VERSION)

Re: [PATCH v8 0/7] speed up index load through parallelization

2018-10-11 Thread Junio C Hamano
Ben Peart writes: > From: Ben Peart > > Fixed issues identified in review the most impactful probably being plugging > some leaks and improved error handling. Also added better error messages > and some code cleanup to code I'd touched. > > The biggest change in the interdiff is the impact of

[PATCH v8 0/7] speed up index load through parallelization

2018-10-10 Thread Ben Peart
From: Ben Peart Fixed issues identified in review the most impactful probably being plugging some leaks and improved error handling. Also added better error messages and some code cleanup to code I'd touched. The biggest change in the interdiff is the impact of renaming ieot_offset to